Issue 1130 and 1131 smdb norc tools #689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 20, 2024 02:05
added 2 commits
November 25, 2024 08:53
Gbarra9
requested review from
a team,
anthonypetersen and
amber-emmes
and removed request for
a team
amber-emmes
reviewed
Nov 25, 2024
| return res.status(405).json(getResponseJSON('Only POST requests are accepted!', 405)); | ||
| } | ||
| let body = req.body; | ||
| const { connectId, currentPaymentRound, dateOfEligibility } = body; |
There was a problem hiding this comment.
does dateOfEligibility need to be null checked?
| * @param {string} paymentRound - Payment round to check eligibility for participant | ||
| * @returns {object} - Object with isEligibleForIncentive boolean and participantData object | ||
| */ | ||
| const checkParticipantForEligibleIncentive = async (connectId, currentPaymentRound) => { |
There was a problem hiding this comment.
I might be misunderstanding part of the workflow, but why is this end-point necessary?
| * @returns {object} - Object with isEligibleForIncentive boolean and participantData object | ||
| */ | ||
| const checkParticipantForEligibleIncentive = async (connectId, currentPaymentRound) => { | ||
| try { |
There was a problem hiding this comment.
If you wanted to try a simpler approach, you might be able to use the existing function that checks for incentive eligible participants (called from incentive.js) and then see if the returned object contains the participant being checked.
anthonypetersen
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to
Reference Derived Variables Rules: https://nih.app.box.com/file/1668730770583?s=kc8ugxvosd9h5z3glinufwr0thvwlpgi
Information of updates
Reset Participant's SSN Survey
Participant Update Incentive Eligibility Update
130371375.266600170.731498909 (Payment Round, baseline, Eligible for Payment) - 353358909 (Yes)
130371375.266600170.222373868 (Payment Round, baseline, NORC Payment Eligibility) = 353358909 (Yes)
130371375.266600170.787567527 (Payment Round, baseline, auto generated date when payment eligible for payment round) -<Current ISO 8601 Timestamp>
Code changes:
Added new endpoints for dashboard API resetParticipantSurvey, checkParticipantForEligibleIncentive, and updateParticipantIncentiveEligibility