Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1: User Profile Enhancements for Intro and MyProfile page (December Release) #994

Open
cusackjm opened this issue Apr 30, 2024 · 27 comments
Assignees
Labels
CCC Priority 1 Issues to be addressed in the current release PWA

Comments

@cusackjm
Copy link
Collaborator

cusackjm commented Apr 30, 2024

Requirements here: https://nih.app.box.com/file/1674557082093
Edits to User Profile Criteria

  1. Language Content Changes and introduction text update on the introduction/main screen page(before User Profile page). Changes listed on Criteria here in orange
  2. Require double entry of data of birth field with a QC check before committing data(with confirmation entry and error if both entries doesn't match). Only needs to be stored in data once
  • Confirmation Entry should be formatted vertically and to the right of the initial DOB entry(that is saved)
  1. Add place of birth under 'Date of birth' section
  • New Variables to be created to be stored in participants table:
    Place of Birth (not nested, not required)
    1. City
    2. State
    3. Country

  • Open text fields added for fields 'City', 'State', 'Country'. No dropdown for State if 'Out of US'

  1. Lock middle name and suffix from being editable on user profile. Should be exported from consent and not be changed
@cusackjm cusackjm added the PWA label Apr 30, 2024
@sonyekere sonyekere added CCC Backlog CCC Priority 2 Issues will be prioritized in the upcoming/next release and removed CCC Backlog CCC Priority 2 Issues will be prioritized in the upcoming/next release labels May 13, 2024
@rohanjay10
Copy link
Collaborator

rohanjay10 commented Oct 28, 2024

Current Items for discussion(commented on UP requirements doc):

  • Guidance on what modal/confirmation looks like when invoking USPS API check, once development starts
  • Confirm Physical Address is also run through USPS API filter
  • Confirm that storing names under the UserProfile history nested structure for UP Name fields before initial API pull of UP data will not break sites process

@sonyekere sonyekere added CCC Priority 1 Issues to be addressed in the current release and removed CCC Backlog labels Oct 31, 2024
@jhflorey jhflorey self-assigned this Nov 1, 2024
@robertsamm robertsamm changed the title Edits to User Profile (Need IRB review - Future Release) User Profile Enhancements (December Release) Nov 1, 2024
@rohanjay10 rohanjay10 changed the title User Profile Enhancements (December Release) User Profile Enhancements for Intro and MyProfile page (December Release) Nov 4, 2024
@sonyekere sonyekere changed the title User Profile Enhancements for Intro and MyProfile page (December Release) Part 1: User Profile Enhancements for Intro and MyProfile page (December Release) Nov 7, 2024
@rohanjay10
Copy link
Collaborator

Hi all, messaged with @bransteitterbr and adding that all the new UP update text and error messages on the PWA needs to be translated into Spanish (including Former Name #1150 and Contact Information #1149 changes). Messaged with @depietrodeanna about this and once we have everything that needs to be translated finalized, it would be helpful to have it all compiled in one place.
Some error messages we need: Double Entry DOB if 2nd entry does not match, Possibly Place of Birth, email validation typo messages, and Mailing/Physical address errors.

@robertsamm I think we may have to add this to the requirements document

@rohanjay10
Copy link
Collaborator

Updating that we met today to discuss UP Spanish Translations:
Next steps/Updates

  • UP Content for translation is almost finalized and should be coming back tomorrow
  • MyProfiles page translations should mimic translations done on User Profile Page, for respective matching components
  • Me and Amelia to work on a document compiling a list of error messages and labels to be translated into Spanish

Please feel free to add on or update the above

@robertsamm
Copy link
Collaborator

Spanish translation of the User Profile content is located on Box here: https://nih.app.box.com/file/1699219693658

@rohanjay10
Copy link
Collaborator

Here is the latest draft of the UP updates error messages, to be translated, located on Box here: https://app.box.com/s/h1jdjwe8ah3ydkwfcaow223q3irae2i4

Please feel free to review/add on

@jhflorey
Copy link
Collaborator

@rohanjay10 @mnataraj92 have we had the new conceptids

@mnataraj92
Copy link
Collaborator

mnataraj92 commented Nov 15, 2024

User Profile Updates Variables/CIDs:

Place of Birth- City (RcrtUP_PoBCity_v1r0): d_876546260

Place of Birth- State (RcrtUP_PoBState_v1r0): d_337485417

Place of Birth- Country (RcrtUP_PoBCountry_v1r0): d_384576626

Flag for if Mailing address is a PO Box (RcrtUP_POBox_v1r0): d_250235523

@mnataraj92
Copy link
Collaborator

The following will get added to the User Profile History (under d_569151507):

Physical Address- Address line 1 (RcrtUP_PhysAddressLn1_v1r0): d_207908218

Physical Address- Address line 2 (RcrtUP_PhysAddressLn2_v1r0): d_224392018

Physical Address- City (RcrtUP_PhysCity_v1r0): d_451993790

Physical Address- State (RcrtUP_PhysState_v1r0): d_187799450

Physical Address- Zip (RcrtUP_PhysZip_v1r0): d_449168732

@rohanjay10
Copy link
Collaborator

Here is the latest draft of the UP updates error messages, to be translated, located on Box here: https://app.box.com/s/h1jdjwe8ah3ydkwfcaow223q3irae2i4

Please feel free to review/add on

Hi @depietrodeanna , Jessica needs the Spanish translations for pt 1 and pt 2 error messages, and I wanted to check if you got a chance to send over the Spanish translation error messages for part 1(date of birth) and part 2(former names) to NORC/Glyph?

@depietrodeanna
Copy link
Collaborator

Screenshot 2024-11-19 at 8 11 38 AM

@rohanjay10 I can pass these off for quick translation today. Are the rest of the error messages in that document finalized for translation as well or should I wait on those?

@rohanjay10
Copy link
Collaborator

@depietrodeanna Great thanks. The other error messages(pt 3) are not finalized yet so yes please wait on those

@depietrodeanna
Copy link
Collaborator

Submitted and asked for delivery by EOW.

@rohanjay10
Copy link
Collaborator

Thanks for the update. @jhflorey @robertsamm @sonyekere keeping all of you in the loop on this as well - Pt 1 and Pt2 error messages translations should be delivered by EOW.

@rohanjay10
Copy link
Collaborator

Hi all, confirmed with @jhflorey that the UP Part 1 changes are ready for Dev testing (apart from the pending pt 1 Spanish translations noted above)

@depietrodeanna
Copy link
Collaborator

@rohanjay10 and @jhflorey NORC relayed this content back in Spanish for DOB and former name error messages:
Screenshot 2024-11-21 at 12 46 57 PM

@rohanjay10
Copy link
Collaborator

Great thanks for the update. Copying to UP Pt2 Issue #1150

@jhflorey
Copy link
Collaborator

@rohanjay10 and @jhflorey NORC relayed this content back in Spanish for DOB and former name error messages: Screenshot 2024-11-21 at 12 46 57 PM

@depietrodeanna could you please paste the text. You just sent the image and i can not copy/paste it.

@robertsamm
Copy link
Collaborator

Hi @jhflorey I have copied and pasted the Spanish translation of pt 1 and pt 2 error messages into the error message doc on Box here: https://nih.app.box.com/file/1699379771757

@rohanjay10
Copy link
Collaborator

rohanjay10 commented Dec 5, 2024

Hi all, I've added notes/action items from UP Pt1, Pt2 testing. Please add anything else needed.

UP Pt1/2 Testing

Introduction Text

  • Remove extra hyper link for "myconnect.cancer.gov/support" in last part of introduction text

DOB

  • Suggestion is to have this formatted horizontally:
    Month Day Year
    "Please re-enter DOB"
    Month Day Year
  • "Please re-enter DOB" Language text to indicate why there are two sets of fields for DOB double entry(@robertsamm and @depietrodeanna to work on this)

When zooming in for a smaller screen:

  • Former name and DOB fields need to be formatted correctly

@jhflorey to go through UI on phone/tablet and look into implementing responsive design checking with DevOps

UP Pt 1, Pt2 Testing Day 2:

Scenario 6: HP, Scenario 7: Henry Ford

  • Site to pull UP name and confirm. @mnataraj92 to confirm site is able to pull back former name data and does not affect current procedures for verification

Former Names

  • When Former Names name value has a number there is no error when submitted. It needs the same QC and error message shown when a number is entered in the Consent Name

Spanish Translations:
Introduction Text
• Introduction text page before User Profile needs to have hyperlink removed(MyConnect.cancer.gov/support)
• Last sentence: "Si tiene alguna pregunta, comuníquese con el Centro de Asistencia de Connect desde MyConnect.cancer.gov/support."

DOB
• "Please re-enter Date of Birth" to be translated into Spanish
• DOB language changes from English testing to be translated to Spanish, indicating why DOB requires double entry.
• Confirm double entry of "month"/"day"/"year" are in Spanish

Former Names
• Error message for former name dropdown shows up in English but should be in Spanish

  • When Former Names name value has a number there is no error when submitted. It needs the same QC and error message shown when a number is entered in the Consent Name

• The Spanish error message shown for this error on the Consent Name field also needs to be shown in the Spanish text for the Former Names field

User Profile Review responses confirmation screen(after submitting)
• Former names(first name, middle name, last name) and Place of Birth(city, state, country) shows up in English and needs to be translated into Spanish

• Deanna to double check the Spanish state dropdown values

PWA Bootstrap changes
• Check list of Bootstrap 5 changes/updates for PWA #1167

@rohanjay10
Copy link
Collaborator

Additional information/items for UP testing (also updated in the appropriate fields in previous comment:

Former Names

  • When Former Names name value has a number there is no error when submitted. It needs the same QC and error message shown when a number is entered in the Consent Name
  • The Spanish error message shown for this error on the Consent Name field also needs to be shown in the Spanish text for the Former Names field
  • @depietrodeanna to double check the Spanish state dropdown values

@mnataraj92
Copy link
Collaborator

mnataraj92 commented Dec 6, 2024

Vijay from HP and Eusuf from HFH both confirmed that they are able to pull back former name data in dev and it does not interfere with any of their existing processes.

Vijay noted that he feels the user profile history could be extremely useful for their manual matching process and wants to have a discussion with the HP internal team to explore how they can best utilize this information.

@depietrodeanna
Copy link
Collaborator

depietrodeanna commented Dec 6, 2024

Hi all, I've added notes/action items from UP Pt1, Pt2 testing. Please add anything else needed.

UP Pt1/2 Testing

Introduction Text

  • Remove extra hyper link for "myconnect.cancer.gov/support" in last part of introduction text

DOB

  • Suggestion is to have this formatted horizontally:
    Month Day Year
    "Please re-enter DOB"
    Month Day Year
  • "Please re-enter DOB" Language text to indicate why there are two sets of fields for DOB double entry(@robertsamm and @depietrodeanna to work on this)

When zooming in for a smaller screen:

  • Former name and DOB fields need to be formatted correctly

@jhflorey to go through UI on phone/tablet and look into implementing responsive design checking with DevOps

UP Pt 1, Pt2 Testing Day 2:

Scenario 6: HP, Scenario 7: Henry Ford

  • Site to pull UP name and confirm. @mnataraj92 to confirm site is able to pull back former name data and does not affect current procedures for verification

Former Names

  • When Former Names name value has a number there is no error when submitted. It needs the same QC and error message shown when a number is entered in the Consent Name

Spanish Translations: Introduction Text • Introduction text page before User Profile needs to have hyperlink removed(MyConnect.cancer.gov/support) • Last sentence: "Si tiene alguna pregunta, comuníquese con el Centro de Asistencia de Connect desde MyConnect.cancer.gov/support."

DOB • "Please re-enter Date of Birth" to be translated into Spanish • DOB language changes from English testing to be translated to Spanish, indicating why DOB requires double entry. • Confirm double entry of "month"/"day"/"year" are in Spanish

Former Names • Error message for former name dropdown shows up in English but should be in Spanish

  • When Former Names name value has a number there is no error when submitted. It needs the same QC and error message shown when a number is entered in the Consent Name

• The Spanish error message shown for this error on the Consent Name field also needs to be shown in the Spanish text for the Former Names field

User Profile Review responses confirmation screen(after submitting) • Former names(first name, middle name, last name) and Place of Birth(city, state, country) shows up in English and needs to be translated into Spanish

• Deanna to double check the Spanish state dropdown values

PWA Bootstrap changes • Check list of Bootstrap 5 changes/updates for PWA #1167

Language for DOB double entry in English: "Please confirm your date of birth by re-entering your information." Getting this translated and will update here.

@rohanjay10 language for DOB double entry in Spanish: "Por favor, confirme su fecha de nacimiento volviendo a ingresar su información."

@rohanjay10
Copy link
Collaborator

  • When Former Names name value has a number there is no error when submitted. It needs the same QC and error message shown when a number is entered in the Consent Name

Hi @depietrodeanna could you please provide the Spanish text for the Former name error:
"Your former name should contain only uppercase and lowercase letters. Please do not use any numbers or special characters."

@depietrodeanna
Copy link
Collaborator

depietrodeanna commented Dec 11, 2024

@rohanjay10 First set of error messages in Spanish delivered from NORC (I know the soft suggestion is for a future release, but so we have it on record):

English:
This email address is invalid. Please enter a valid email before continuing.
Spanish: Esta dirección de correo electrónico no es válida. Por favor, introduzca un correo electrónico válido antes de continuar.

English:
Warning- this email address may be invalid. Please double check your entry before continuing.
Spanish: Advertencia: esta dirección de correo electrónico puede no ser válida. Por favor, vuelva a revisar su entrada antes de continuar.

English: Did you mean [insert email @ email client]?
Spanish: ¿Quería decir [insert email @ email client]?

@jhflorey
Copy link
Collaborator

@rohanjay10 @depietrodeanna we need the Spanish text for the following:

  • "Your former name should contain only uppercase and lowercase letters. Please do not use any numbers or special characters."
  • "Mailing address is PO Box"

@depietrodeanna
Copy link
Collaborator

Hi @jhflorey, I passed off to NORC for translation and will share the Spanish here.

@sonyekere
Copy link
Collaborator

@depietrodeanna Thanks for passing on the translations to NORC! Do you foresee us not receiving those translations within the next hour? No immediate rush, it's just that Jessica may not be able to include the Spanish content in time for testing this afternoon. The translations can be incorporated into the code once NORC delivers them to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCC Priority 1 Issues to be addressed in the current release PWA
Projects
Development

No branches or pull requests

9 participants