Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Magic Link Emails Received on Continue Click (Sign in -> Continue) (PWA) #1156

Open
JoeArmani opened this issue Nov 14, 2024 · 1 comment
Assignees

Comments

@JoeArmani
Copy link
Collaborator

The sign-in process occasionally sends two magic links, back-to-back, where the links are different and the second one would likely invalidate the first one.

Something in the Continue button’s click handling could be creating a double-click operation internally. Something firing twice server-side could also lead to the double magic link message.

We should look at debouncing the button when clicked as a first step in ensuring the process isn’t triggered twice.

Screenshots showing the result where the magic links are different -- they're separate messages, not duplicate messages:

Screenshot 2024-11-13 at 2 56 12 PM Screenshot 2024-11-13 at 3 00 12 PM Screenshot 2024-11-13 at 2 59 57 PM
@JoeArmani
Copy link
Collaborator Author

The initial step to resolve this issue is included with the PR for #1167, so we'll check in testing. Local testing has been successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants