Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 2: User Profile Enhancements for Former Names (December Release) #1150

Open
rohanjay10 opened this issue Nov 1, 2024 · 8 comments
Open
Assignees
Labels
CCC Priority 1 Issues to be addressed in the current release

Comments

@rohanjay10
Copy link
Collaborator

rohanjay10 commented Nov 1, 2024

Original Issue: Issue #994
Requirements here: https://nih.app.box.com/file/1674557082093
Edits to User Profile Criteria

Add field for 'Former Names' in 'Names' section.

Variable Updates/Requirements:

  • To be retained in User Profile history and stored under the nesting structure for User Profile (first, middle, last) name
  • Former names for First, Middle, Last names are stored under current User Profile history name field nesting structure for User Profile name(First/Middle/Last). This is an array in DD structure, on PWA there is a soft limit of 50.
  • Current name would remain current User Profile Name, it would not be overwritten. Former Name entered would be backfilled into history variable. Consent name does not change

UI

  1. Add intro text(on above Criteria document page 3) on MyProfile page
  2. 'Former Names' to be added as sub category after 'Preferred first name' field in 'Names' section
  3. Displayed as drop down with responses of 'First', 'Middle', 'Last', and open field text box to type Former Name(stored under User Profile name nesting structure). Display 2 entries with ability to add more(soft limit of 50).
  4. Drop Down required if data is entered into textbox. Display error: 'Please choose a name category. If you do not have a name to enter, please remove text from Former Name textbox’
  5. All new text on the PWA, including error messages, to be translated into Spanish

Testing Dependencies:

  • Confirm during testing that 'former names' are imported into the user profile history variable only and that the consent name and current user profile names are locked down (so not edited when former names are entered).
  • Confirm this in all places name is displayed (consent name and user profile name on site API, SMDB, PWA MyProfiles page, BSD)

Please add any additional information/changes below. Thanks

@sonyekere sonyekere added the CCC Priority 1 Issues to be addressed in the current release label Nov 4, 2024
@sonyekere sonyekere changed the title User Profile Enhancements for Former Names (December Release) Part 2: User Profile Enhancements for Former Names (December Release) Nov 7, 2024
@jhflorey
Copy link
Collaborator

@robertsamm do we need to have a remove button to remove each field?

@jhflorey
Copy link
Collaborator

@rohanjay10 @mnataraj92 Do we have new concept ids for this issue.

@mnataraj92
Copy link
Collaborator

Hi @jhflorey former names will not have new concept IDs. Former names will get stored in the UP History (d_569151507) in the same existing variables as UP first name (d_569151507_d_399159511), last name (d_569151507_d_996038075), middle name (d_569151507_d_231676651), and suffix (d_569151507_d_506826178). They'll be nested under the array for user profile history names.

@jhflorey
Copy link
Collaborator

@mnataraj92 should it be like the example below

569151507: [
{
      '371303487': '2024-10-22T21:37:00.265Z',
      '399159511': ['fn1', 'fn2', ...],
      '996038075': ['ln1', 'ln2', ...]
      '231676651': ['mn1', 'mn2', ...],
    },
]

@mnataraj92
Copy link
Collaborator

@jhflorey yes!

@JoeArmani
Copy link
Collaborator

Here's a reference screenshot of the UPHistory data structure from a dev testing account. I think it's important to match this structure for potential long-term needs.
Screenshot 2024-11-20 at 4 12 18 PM

@rohanjay10
Copy link
Collaborator Author

Former names error message translated in Spanish by NORC

@jhflorey
Copy link
Collaborator

@rohanjay10 my code changes are ready in dev. We can test part 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCC Priority 1 Issues to be addressed in the current release
Projects
Development

No branches or pull requests

6 participants