Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add featuring masks/enable #124

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

agaget
Copy link
Contributor

@agaget agaget commented Jan 29, 2024

This PR add mask (and enable) functionalities for the sequencer. See chapter 2.4 Event Sequencer (of the 2021 manual maybe it's updated now)

image

It add possibility of the sofware mask/enable (register SQSWMASK and SQSWENA) and mask attached to physical input. See register FP0SQMK and FP0SQEEN.

I've added and iocseqmask to have an example. It works with an MTCA EVM300 and MTCA EVR300U, using backplanes as physical input and output.

For SARAF MPS we are using the mask functionnality to stop producing the chopper pulse, stop the magnetron, but not stopping RF, so we are masking events of the sequence without stopping the sequencer.

@agaget agaget requested a review from jerzyjamroz as a code owner January 29, 2024 09:23
@jerzyjamroz jerzyjamroz self-assigned this Jan 31, 2024
@jerzyjamroz
Copy link
Contributor

@agaget , thanks for this feature. Could you rebase it to the master branch?

@agaget agaget force-pushed the add-feat-masks branch 2 times, most recently from ce2c352 to 361452f Compare January 31, 2024 10:30
@agaget
Copy link
Contributor Author

agaget commented Jan 31, 2024

@agaget , thanks for this feature. Could you rebase it to the master branch?

It should be ok now.
I have tested again the ioc to check no regression, it works fine

@agaget
Copy link
Contributor Author

agaget commented Jan 31, 2024

One more thing if it's possible after the PR to increment the tag number please ? Not necessary major version but 2.5.1
Except if you already plan to increment it soon
Thanks

@jerzyjamroz
Copy link
Contributor

@agaget , I did an initial review and your work looks well thought out and tested.
On the other hand, I will need more time to go deep into it to give you feedback (I am busy at this moment), and I do not want to block you. It means I will merge it now and if any feedback appears, I will propose a PR for your review, and then it will get the tag.

One comment:

#Can't dbpf waveform of UCHAR so we use this. Change architecture if needed.

I think you can contribute to the dbpf tool to have the capability to write digits to it. It would be useful for the whole community.

@jerzyjamroz jerzyjamroz merged commit 77e6f5c into epics-modules:master Feb 14, 2024
11 checks passed
@agaget
Copy link
Contributor Author

agaget commented Feb 14, 2024

@agaget , I did an initial review and your work looks well thought out and tested. On the other hand, I will need more time to go deep into it to give you feedback (I am busy at this moment), and I do not want to block you. It means I will merge it now and if any feedback appears, I will propose a PR for your review, and then it will get the tag.

I'm glad that it's merged now and I'm fine with your proposition

I think you can contribute to the dbpf tool to have the capability to write digits to it. It would be useful for the whole community.

I agree and I'd like to look at it, unfortunately like you I'm quite busy lately and it's not going better..

Thanks

@agaget
Copy link
Contributor Author

agaget commented Feb 14, 2024

And is it possible to tag to 2.5.1 please ?

@jerzyjamroz
Copy link
Contributor

It is 2.6 already as there are other things included in regards to 2.5. I will mark it but without making the release.

@agaget
Copy link
Contributor Author

agaget commented Feb 14, 2024

It is 2.6 already as there are other things included in regards to 2.5. I will mark it but without making the release.
Ok perfect, no need for 2.5.1 if this is in 2.6. The tag just appear for me I wasn't able to see it before.

@jerzyjamroz jerzyjamroz linked an issue Sep 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM input mask record name and driver function name
2 participants