-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add featuring masks/enable #124
Conversation
@agaget , thanks for this feature. Could you rebase it to the master branch? |
ce2c352
to
361452f
Compare
It should be ok now. |
One more thing if it's possible after the PR to increment the tag number please ? Not necessary major version but 2.5.1 |
9ee1b46
to
5ba3a7b
Compare
5ba3a7b
to
e3211c3
Compare
e3211c3
to
35e9d7d
Compare
@agaget , I did an initial review and your work looks well thought out and tested. One comment:
I think you can contribute to the |
I'm glad that it's merged now and I'm fine with your proposition
I agree and I'd like to look at it, unfortunately like you I'm quite busy lately and it's not going better.. Thanks |
And is it possible to tag to 2.5.1 please ? |
It is 2.6 already as there are other things included in regards to 2.5. I will mark it but without making the release. |
|
This PR add mask (and enable) functionalities for the sequencer. See chapter 2.4 Event Sequencer (of the 2021 manual maybe it's updated now)
It add possibility of the sofware mask/enable (register SQSWMASK and SQSWENA) and mask attached to physical input. See register FP0SQMK and FP0SQEEN.
I've added and iocseqmask to have an example. It works with an MTCA EVM300 and MTCA EVR300U, using backplanes as physical input and output.
For SARAF MPS we are using the mask functionnality to stop producing the chopper pulse, stop the magnetron, but not stopping RF, so we are masking events of the sequence without stopping the sequencer.