Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM input mask record name and driver function name #180

Open
hongran opened this issue Sep 23, 2024 · 3 comments · Fixed by #124
Open

EVM input mask record name and driver function name #180

hongran opened this issue Sep 23, 2024 · 3 comments · Fixed by #124
Assignees
Labels

Comments

@hongran
Copy link
Contributor

hongran commented Sep 23, 2024

I have one concern about the Hw masks implemented in https://urldefense.us/v3/__https://github.com/epics-modules/mrfioc2/pull/124__;!!G_uCfscf7eWS!broV99Q0qicXStU7HxjH-zQqBKfbM2Lopx3IzjjpDqvdR-r9a_qV0BToBEdrucnsfMxTmZGMpuT8ymzRSSc$

The evg register names EVG_INP_FP_MASK and EVG_INP_FP_MASK _shift, the record name FPMask-Sel indicates that these are for front-panels only. However, they can be applied to any hardware inputs. Also, they only mask the sequencer events.

Can we change the FP into SQ in these names to avoid this confusion?

@agaget , could you take a look at this issue? Thanks!

@agaget
Copy link
Contributor

agaget commented Sep 24, 2024

Hello,
It's been a long time since I did that (merged only few month ago, but implemented 4 or 5 years ago) so I'm not totally into the code, but I've looked in the doc and it's called FPxSQMky

image

There is a clear difference with UIxSQMK
image

Not clear from me what is UIxSQMK, maybe it depends on the EVM used....
For MTCA I suppose the Univ0 to Uni15 are considered to be FP input for the internal EVG ? why not UI Input ??
image

To conclude we can add SQ to add information but not remove FP

@hongran
Copy link
Contributor Author

hongran commented Sep 24, 2024

@agaget Hello, thanks for your reply.
If I understand it correctly, these generic functions can be applied to all types of input, not just the FP. EVG_INP_FP_MASK is a shift relative to a base address of an output channel. For both FP and UI, the MASK is bit 31-28, the difference is the base address.
As you pointed out, Univ Input for EVM-300 are internally wired for interfacing with the EVRU and EVRD.

Besides FP and UI, there are also transition board inputs that can be used as the MASK source:
image

The transition board is on the rear side, so using FP in it may cause confusions. That's my main concern.

Thanks!

@jerzyjamroz jerzyjamroz linked a pull request Sep 25, 2024 that will close this issue
@agaget
Copy link
Contributor

agaget commented Sep 26, 2024

@agaget Hello, thanks for your reply. If I understand it correctly, these generic functions can be applied to all types of input, not just the FP. EVG_INP_FP_MASK is a shift relative to a base address of an output channel. For both FP and UI, the MASK is bit 31-28, the difference is the base address. As you pointed out, Univ Input for EVM-300 are internally wired for interfacing with the EVRU and EVRD.

Besides FP and UI, there are also transition board inputs that can be used as the MASK

The transition board is on the rear side, so using FP in it may cause confusions. That's my main concern.

Thanks!

Ok, I step by step remember all this stuff and I understand better your issue. I will take a look at it as soon as I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants