Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEQ run mode #133

Open
Insomnia1437 opened this issue Feb 29, 2024 · 3 comments
Open

SEQ run mode #133

Insomnia1437 opened this issue Feb 29, 2024 · 3 comments

Comments

@Insomnia1437
Copy link
Contributor

The run mode setting of SEQ RAM seems strange.
Inside mrmShared/Db/mrmSoftSeq.template, no automatic mode field is specified in $(P)RunMode-Sel though $(P)RunMode-RB has.

record(mbbo, "$(P)RunMode-Sel") {
...
  field(VAL,  "1") # default to Single
  field(ZRVL, "0")
  field(ONVL, "2")
  field(ZRST, "Normal")
  field(ONST, "Single")
...
}
record(mbbi, "$(P)RunMode-RB") {
...
  field(ZRVL, "0")
  field(ONVL, "1")
  field(TWVL, "2")
  field(ZRST, "Normal")
  field(ONST, "Automatic")
  field(TWST, "Single")
...
}

Only normal and single modes are defined here.

switch(committed.mode) {
case Single:
hw->ctrlreg_user |= EVG_SEQ_RAM_SINGLE;
break;
case Normal:
hw->ctrlreg_user |= EVG_SEQ_RAM_NORMAL;
break;
}

@jerzyjamroz jerzyjamroz self-assigned this Mar 1, 2024
@jerzyjamroz
Copy link
Contributor

jerzyjamroz commented Mar 1, 2024

@Insomnia1437 , I checked it and it looks like the author removed that on purpose and it is the residual remain that will never occur. Do you have any use cases of that Automatic mode?

@jerzyjamroz jerzyjamroz added the bug label Mar 1, 2024
@Insomnia1437
Copy link
Contributor Author

Currently, no. But if I want to run some automatic tests for EVM&EVR, then this feature can be helpful. If you think it is better to revert the change, perhaps I can fix it.

@zioven
Copy link
Contributor

zioven commented Mar 1, 2024

@Insomnia1437 @jerzyjamroz

We have found a use case for the Automatic mode and we have a working solution for one of our customers.

A word of caution: as @jerzyjamroz commented this mode does come with it's set of challenges, one of them is how to stop the sequence...

Let me know, if there is interest for this in the community and I can provide a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants