Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move base python version to 3.12 #115

Open
diehlbw opened this issue Dec 4, 2024 · 1 comment
Open

Move base python version to 3.12 #115

diehlbw opened this issue Dec 4, 2024 · 1 comment
Labels
compatibility Tracks a more fundamental change that may take planning to accomodate

Comments

@diehlbw
Copy link
Collaborator

diehlbw commented Dec 4, 2024

This issue is to document and track the expectation to move the base python version forward.

Currently, core testing is done in a py3.10 environment with test suite verifying stability in 3.11.
We will be moving this forward, targeting 3.12 as a baseline and starting to test in 3.13.

python version table

This is NOT removing support for either 3.10 or 3.11 (see issues: #116)

@diehlbw diehlbw added enhancement New feature or request compatibility Tracks a more fundamental change that may take planning to accomodate and removed enhancement New feature or request labels Dec 4, 2024
@firste
Copy link
Collaborator

firste commented Dec 4, 2024

Here is what I tried and what was remaining:

  • in setup.cfg, change python_requires to >=3.12
  • in Dockerfile, change the first line to FROM python:3.12-slim as seismometer
  • In requirements.txt, here are the changes I made that partially worked:
    • numpy>=1.26
    • numba>=0.59.0
    • scikit-learn>=1.3.1

The example notebook fully works (and is pretty snappy compared to before) but the tests fail with the following error -

ERROR tests/report/test_alerts.py - AttributeError: module 'numba' has no attribute 'generated_jit'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Tracks a more fundamental change that may take planning to accomodate
Projects
None yet
Development

No branches or pull requests

2 participants