Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off by one error in frame iterators #30

Open
willprice opened this issue Oct 19, 2018 · 0 comments
Open

Off by one error in frame iterators #30

willprice opened this issue Oct 19, 2018 · 0 comments

Comments

@willprice
Copy link
Member

The frame iterators in each modality only go up to the stop_frame - 1, these should probably be inclusive bounds i.e. range(start_frame, stop_frame - 1).

https://github.com/epic-kitchens/epic-lib/blob/master/epic_kitchens/video.py#L41
https://github.com/epic-kitchens/epic-lib/blob/master/epic_kitchens/video.py#L54

Spotted by @ekazakos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@willprice