Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethcall id bug #46

Closed
stephenpdeos opened this issue Sep 13, 2023 · 1 comment · Fixed by #47 or #49
Closed

ethcall id bug #46

stephenpdeos opened this issue Sep 13, 2023 · 1 comment · Fixed by #47 or #49
Assignees
Labels
bug Something isn't working 👍 lgtm

Comments

@stephenpdeos
Copy link
Member

stephenpdeos commented Sep 13, 2023

Related to #33

@stephenpdeos stephenpdeos converted this from a draft issue Sep 13, 2023
@stephenpdeos stephenpdeos added bug Something isn't working 👍 lgtm labels Sep 13, 2023
@elmato
Copy link
Contributor

elmato commented Sep 13, 2023

Pasting here @taokayan comments on Telegram.

the new eos-evm-node still generating the id format error in some cases:

{"id": "fddfe7af-4ea1-4d06-9ced-a256d8141dc1", "jsonrpc": "2.0", "method": "eth_call", "params": [{"to": "0x3A13A4653761299D8b9D0D5DCaC100D0c961938B", "data": "0x70a082310000000000000000000000002787b98fc4e731d0456b3941f0b3fe2e01439961"}, "0xe1"]}

resp is:

{"jsonrpc": "2.0", "id": "\"fddfe7af-4ea1-4d06-9ced-a256d8141dc1\"", "error": {"code": 100, "message": "[json.exception.type_error.302] type must be number, but is string"}}

seems the culprit is:
void make_glaze_json_content(std::string& reply, uint32_t id, const Logs& logs)

@elmato elmato moved this from Todo to Awaiting Review in EOS EVM Sep 13, 2023
@arhag arhag added this to the EVM Node 0.6.0-rc2 milestone Sep 14, 2023
@arhag arhag linked a pull request Sep 19, 2023 that will close this issue
@arhag arhag closed this as completed in #49 Sep 19, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in EOS EVM Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm
Projects
Status: Done
3 participants