Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a JavaScript/TypeScript Linter to the DevHub Projects #17

Open
kj4ezj opened this issue Dec 22, 2022 · 0 comments
Open

Add a JavaScript/TypeScript Linter to the DevHub Projects #17

kj4ezj opened this issue Dec 22, 2022 · 0 comments
Assignees
Labels
CICD Continuous integration, continuous deployment - build and test system

Comments

@kj4ezj
Copy link
Contributor

kj4ezj commented Dec 22, 2022

Following devrel issue 135, this issue has a JavaScript or TypeScript linter being added to each of the projects in this repo (three projects at the time of this writing), and being a required check on all builds.

The author recommends eslint with a linter configuration in the package.json similar to this. The eslint-config-airbnb-base is quite picky so there may be many rules that can and should be disabled. The author recommends restricting rules that cause a linter error (and thus a build failure) only to rules that possibly indicate a mistake. All other rules should be warnings or disabled. The only linter issues that should truly block a merge or a deployment should be linter issues that may genuinely indicate a mistake with repercussions.

See Also

  • devrel issue 80 - Standup DevHub Infrastructure
  • devrel issue 96 - DNS Mapping for learn.eosnetwork.com
  • devrel issue 134 - Update DevHub Site
  • devrel issue 135 - DevHub Frontend CICD
  • devrel issue 137 - Encrypt DevHub Backend
  • devhub issue 12 - Put AWS Resources into Terraform with a CICD Deployment
  • devhub issue 13 - Document CICD System
  • devhub issue 14 - Staging Environment
  • devhub issue 15 - Backend CICD
  • devhub issue 16 - Structures CICD
  • devhub issue 17 - Add a JavaScript/TypeScript Linter to the DevHub Projects
  • devhub issue 18 - Add BASH Linters for CICD Code
  • devhub issue 19 - Include Test Suite in CICD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD Continuous integration, continuous deployment - build and test system
Projects
Status: Todo
Development

No branches or pull requests

1 participant