docs: update prerequisites files with installation and connectivity t… #5094
+126
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esting steps Signed-off-by: DeeBi9 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5094 +/- ##
==========================================
+ Coverage 66.80% 66.86% +0.06%
==========================================
Files 210 210
Lines 32953 32953
==========================================
+ Hits 22013 22035 +22
+ Misses 9603 9585 -18
+ Partials 1337 1333 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: DeeBi9 <[email protected]>
arkodg
reviewed
Jan 24, 2025
| helm install eg oci://docker.io/envoyproxy/gateway-helm --version {{< helm-version >}} -n envoy-gateway-system --create-namespace | ||
| ``` | ||
|
|
||
| **Note**: Wait 2–5 minutes for the Envoy Gateway pod to reach the Running state. |
There was a problem hiding this comment.
can we rm this line ? 2-5 min sounds like a long time, and once helm completes, it should be okay to install the Quickstart right away (since CRDs have been installed)
There was a problem hiding this comment.
Thanks for the feedback! I'll remove the line and update the PR accordingly.
Signed-off-by: DeeBi9 <[email protected]>
DeeBi9
force-pushed
the
embed_quickstart_install_steps_in_tasks
branch
from
b3d6e49 to
f463e6f
Compare
|
Hi @arkodg I noticed that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
docs: update prerequisites and embed installation/testing steps
What this PR does / why we need it:
This PR updates the documentation by adding the installation guide and testing configuration steps from the quickstart guide to boilerplate
prerequisites.mdando11y_prerequisites.md. The content is presented in a collapsible format and is a shorter version of the quickstart guide.Which issue(s) this PR fixes:
#5064 (docs: Embed Quickstart Install steps in Tasks rather than link out)
Release Notes:
No