Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use AWS CLI command #5

Open
roni-frantchi opened this issue Jan 25, 2022 · 4 comments
Open

Do not use AWS CLI command #5

roni-frantchi opened this issue Jan 25, 2022 · 4 comments
Labels
wontfix This will not be worked on

Comments

@roni-frantchi
Copy link
Contributor

roni-frantchi commented Jan 25, 2022

The following resources:

module "suspend_asg_processes_command" {
  source           = "digitickets/cli/aws"
  version          = "4.1.0"
  aws_cli_commands = ["autoscaling", "suspend-processes", "--auto-scaling-group-name ${module.eks.node_groups.deployment.resources.0.autoscaling_groups.0.name}", "--scaling-processes AZRebalance"]
}

module "set_asg_default_cooldown_command" {
  source           = "digitickets/cli/aws"
  version          = "4.1.0"
  aws_cli_commands = ["autoscaling", "update-auto-scaling-group", "--auto-scaling-group-name ${module.eks.node_groups.deployment.resources.0.autoscaling_groups.0.name}", "--default-cooldown 60"]
}

module "enable_asg_metrics_collection" {
  source           = "digitickets/cli/aws"
  version          = "4.1.0"
  aws_cli_commands = ["autoscaling", "enable-metrics-collection ", "--auto-scaling-group-name ${module.eks.node_groups.deployment.resources.0.autoscaling_groups.0.name}", "--granularity \"1Minute\""]
}

Upgrading to v18 of the EKS should allow us to set these for node_groups

@roni-frantchi roni-frantchi added the good first issue Good for newcomers label Jan 25, 2022
@roni-frantchi
Copy link
Contributor Author

@GiliFaroEnv0
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 self-assigned this Jan 26, 2022
@roni-frantchi roni-frantchi added wontfix This will not be worked on and removed good first issue Good for newcomers labels Feb 2, 2022
@roni-frantchi
Copy link
Contributor Author

This will require us to transition not only to V18, but also to self managed nodes instead of eks managed nodes - we do not wish to make the switch for these, so for now we will stay with the CLI commands

@chpl
Copy link
Contributor

chpl commented Jun 20, 2024

We can remove those if we replace the autoscaler with karpenter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants