Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce boilerplate when merging rounds #53

Closed
fjarri opened this issue Nov 18, 2023 · 1 comment
Closed

Reduce boilerplate when merging rounds #53

fjarri opened this issue Nov 18, 2023 · 1 comment
Labels
code quality Making things simpler
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Nov 18, 2023

The merged KeyGen + KeyRefresh protocol requires us to write quite a bit of boilerplate where all we do is just merge two types into one or separate them to pass on to lower levels. Can it be done generically?

Seems like we can't do it via a trait, the blanket impl will conflict with the sequential wrapper. Also for the parallel merge we need to assert that round numbers, destinations etc are the same between the two rounds. So a macro would probably be better.

@fjarri fjarri added the code quality Making things simpler label Nov 18, 2023
@fjarri fjarri added this to the v1.0.0 milestone Nov 26, 2023
@fjarri
Copy link
Member Author

fjarri commented Oct 12, 2024

The discussion is moved to entropyxyz/manul#3

@fjarri fjarri closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Making things simpler
Projects
None yet
Development

No branches or pull requests

1 participant