-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: EPNS optin integration #1497
base: dev
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi. Thank you for your contribution.
|
Hello @makoto,
Notice that if a user renew a domain upon receiving the 30 day notification, they will not get the subsequent notifications as the domain will not be in risk any more.
Every time a wallet is checked for domain expiration, it might be the case that only 5 out of the 10 domains are within the notification threshold. So you will receive notifications for these domains only. To compliment 1, 2, 3, above, we are currently working on a new feature called “User Settings”. With Users Settings, users will be able to set their preferences for notifications. In the case of ENS, we are envisioning that users will be able to do things like:
Note- We have updated the Modal UI a bit (as shown in the screenshots) |
Integration of EPNS Opt-in/Opt-out functionality in My Accounts page
Description
On the My Account page, when the user is shown a "Remind Me" drop down, currently we see only "Email". We are now adding a feature to
Opt-In
/Opt-Out
to EPNS notifications so that they can receive notifications from ENS.List of features added/changed
UX wise
Code wise
The entry point of all the EPNS functionality is in
ExpiryNotifyDropdown
which usesEPNSLink
fromcomponents/EPNS
An EPNS folder under
components
has been created which has abstracted all the functionality for this feature. Currently this has many inter-connected components-EPNSLink
- entry point into EPNS featureEPNSNotificationModal
- kicks in whenEPNSLink
is clicked. This wrapper component is provided to do all the heavy lifting for ENS-EPNS bridging.SwitchNetwork
- Utility component to give user 1 click switching of Network to Ethereum main net.useWeb3
hook - This basically gives theEPNSNotificationModal
component the web3 data to make API callsEPNSOnSubscribeModal
- [INTERNAL, will be replaced by NPM package in future]EPNSUtil
- [INTERNAL, will be replaced by NPM package in future][INTERNAL] Currently we are transitioning to smaller individual packages, to avoid increasing the bundle size for ENS (or any dApp), we have extracted out the individual functionalities for Optin, Optout, OnSubscribeModal and placed them in ENS codebase under
components/EPNS
, when we publish those respective NPM packages the end users can simplyimport
these functionalities from the NPM package and delete these files. We will be providing complete support for this.en.json
following ENS i18n practices.How Has This Been Tested?
Locally
OnSubscribeModal
, the same modal you see when you click on the "View Supported Platforms" button. If you close that modal, you will see the EPNS modal with "Opt-Out" text.Switch
button to switch to Main net."Mayday! Mayday! Can the devs do something? They have been notified, please try again a little later!"
Unit Tests
Ran
npm test
on the entire code base -Checklist:
Screenshots