Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses debian bookworm on docker #58

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

leonardocustodio
Copy link
Contributor

@leonardocustodio leonardocustodio commented Nov 6, 2024

PR Type

enhancement, configuration changes


Description

  • Updated the Dockerfile to use a more recent Debian version (bookworm-slim) for the runtime environment.
  • Changed the Rust base image to rust:1.82-bookworm for the build stage.
  • These changes aim to leverage newer libraries and dependencies available in the Bookworm release.

Changes walkthrough 📝

Relevant files
Configuration changes
Dockerfile
Update Dockerfile to use Debian Bookworm and Rust 1.82-bookworm

Dockerfile

  • Updated Rust base image to rust:1.82-bookworm.
  • Changed Debian base image from buster-slim to bookworm-slim.
  • +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Signed-off-by: Leonardo Custodio <[email protected]>
    @leonardocustodio leonardocustodio changed the title Update Dockerfile Uses debian bookworm on docker Nov 6, 2024
    @leonardocustodio leonardocustodio self-assigned this Nov 6, 2024
    Copy link

    github-actions bot commented Nov 6, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    github-actions bot commented Nov 6, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Ensure compatibility of the new Debian version with the application

    Verify compatibility of debian:bookworm-slim with the wallet application, especially
    for any specific dependencies or system libraries that might differ from
    debian:buster-slim.

    Dockerfile [19]

    +FROM debian:bookworm-slim as runner
     
    -
    Suggestion importance[1-10]: 7

    Why: This suggestion is crucial as it addresses potential compatibility issues with the new Debian version, which can affect the application's stability and functionality.

    7
    Possible bug
    Test Docker build for errors after Debian version update

    Test the entire Docker build process to check for any runtime errors or warnings
    that could arise due to the switch to debian:bookworm-slim, focusing on critical
    dependencies like libssl and curl.

    Dockerfile [23]

    +RUN apt-get update && ...
     
    -
    Suggestion importance[1-10]: 7

    Why: Testing the Docker build process is essential to ensure that the application functions correctly with the new Debian version, especially given the critical nature of dependencies like libssl and curl.

    7
    Best practice
    Pin the Debian image to a specific version for consistent builds

    Consider pinning a specific version of debian:bookworm-slim to ensure consistent,
    reproducible builds and avoid unexpected issues from future updates.

    Dockerfile [19]

    -FROM debian:bookworm-slim as runner
    +FROM debian:bookworm-slim@sha256:<digest> as runner
    Suggestion importance[1-10]: 6

    Why: Pinning the Debian image version can significantly enhance the reproducibility and reliability of Docker builds, although it's not a critical issue.

    6
    Enhancement
    Optimize installation commands for the new Debian version

    Review and possibly update the installation commands in the Dockerfile to ensure
    they are optimized for debian:bookworm-slim, which might have different default
    packages or behaviors compared to buster-slim.

    Dockerfile [23]

    +RUN apt-get update && ...
     
    -
    Suggestion importance[1-10]: 5

    Why: Adjusting installation commands for the new Debian version can improve the efficiency and correctness of the build process, but the impact is moderate as it depends on the specific changes in the Debian release.

    5

    @leonardocustodio leonardocustodio merged commit 215216b into master Nov 6, 2024
    4 checks passed
    @leonardocustodio leonardocustodio deleted the leonardocustodio-patch-1 branch November 6, 2024 13:17
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Development

    Successfully merging this pull request may close these issues.

    2 participants