Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sanitycheck VM has HA disks #18

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

lperdereau
Copy link
Collaborator

No description provided.

@lperdereau lperdereau force-pushed the feat-add-sanitychecks-ha-vms branch 2 times, most recently from 16ee6c0 to 251f2e1 Compare November 28, 2024 09:47
@lperdereau lperdereau marked this pull request as ready for review November 28, 2024 15:10
@lperdereau lperdereau requested a review from lcaflc November 28, 2024 15:10
src/pvecontrol/node.py Outdated Show resolved Hide resolved
src/pvecontrol/sanitycheck.py Outdated Show resolved Hide resolved
src/pvecontrol/sanitycheck.py Outdated Show resolved Hide resolved
src/pvecontrol/sanitycheck.py Outdated Show resolved Hide resolved
src/pvecontrol/sanitycheck.py Outdated Show resolved Hide resolved
@lperdereau lperdereau force-pushed the feat-add-sanitychecks-ha-vms branch 3 times, most recently from 748daf4 to 2f4dcf3 Compare December 2, 2024 14:09
@lperdereau lperdereau force-pushed the feat-add-sanitychecks-ha-vms branch from ae4bce4 to 983e7fd Compare December 3, 2024 13:01
@lcaflc
Copy link
Contributor

lcaflc commented Dec 9, 2024

There is an error on a test cluster:

❯ python3 pvecontrol.py -c enix-proxmox-2 sanitycheck
INFO:root:Proxmox cluster: enix-proxmox-2
Traceback (most recent call last):
  File "/home/caf/GIT/Enix/products/pvecontrol/src/pvecontrol.py", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/caf/GIT/Enix/products/pvecontrol/src/pvecontrol/__init__.py", line 145, in main
    args.func(proxmoxcluster, args)
  File "/home/caf/GIT/Enix/products/pvecontrol/src/pvecontrol/actions/cluster.py", line 59, in action_sanitycheck
    exitcode = sc.run(checks=args.check)
               ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/caf/GIT/Enix/products/pvecontrol/src/pvecontrol/sanitycheck/sanitychecks.py", line 26, in run
    check.run()
  File "/home/caf/GIT/Enix/products/pvecontrol/src/pvecontrol/sanitycheck/tests/ha_vms.py", line 22, in run
    self.add_messages(self._check_cpu_ha_consistency(ha_vms))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/caf/GIT/Enix/products/pvecontrol/src/pvecontrol/sanitycheck/tests/ha_vms.py", line 57, in _check_cpu_ha_consistency
    if vm.config['cpu'] == 'host':
       ~~~~~~~~~^^^^^^^
KeyError: 'cpu'

CPU is in fact an option in the API :/

@lperdereau
Copy link
Collaborator Author

@lcaflc I correct error when we access to CPU data, the placeholder is 'Default'.
I see that 'Default' is kvm64 but recently it was update to a new CPU :

In Proxmox VE 8.2.4 the default is "x86-64-v2-AES".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants