Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployed Ruby 2.3(.6) has security vulnerabilities #359

Open
thbar opened this issue Sep 3, 2018 · 5 comments
Open

Deployed Ruby 2.3(.6) has security vulnerabilities #359

thbar opened this issue Sep 3, 2018 · 5 comments

Comments

@thbar
Copy link

thbar commented Sep 3, 2018

In March this year, Ruby 2.3.7 was released, with multiple vulnerability fixes (see here for complete release notes).

If I'm not mistaken, EY instances using Ruby 2.3.x are still on 2.3.6, based on this source code and on ruby -v on a machine I manage.

Ruby 2.3 EOL is still in the future (2019-03-31) and officially supported by EY, so would you welcome a PR to bump Ruby version as well as Rubygems for 2.3?

Thanks!

@thbar
Copy link
Author

thbar commented Sep 3, 2018

(PS: I realise that creating a PR is not the only work you have to do, since you have QA testing etc, so I want to ask first how this may work!)

@thbar
Copy link
Author

thbar commented Sep 18, 2018

Can anyone provide some feedback on this? cc @dvalfre maybe?

If I understand well, this also applies to 2.4 (EY is on 2.4.3, but 2.4.4 has security fixes as well).

Thanks!

@dvalfre
Copy link
Contributor

dvalfre commented Sep 18, 2018

@thbar the packages are there for 2.3.7 and 2.4.4, just run eix dev-lang/ruby. Having said so, the recipes need to be updated. In the meantime, you can overlay the specific file using the approach here.
@jfuechsl @DalianisDim we'll need to put together a PR for updating the default versions, it seems.

@thbar
Copy link
Author

thbar commented Sep 19, 2018

@dvalfre thanks for the feedback!

The "default versions" are what you get when you click "upgrade stack" in the EY UI, is that correct?

This raises an important question for me as an app maintainer: isn't the EY web interface "upgrade stack" button not the recommended way anymore to keep instances updated?

Are most customers actually using the overlay approach (thanks for the link) these days?

Thanks!

@dvalfre
Copy link
Contributor

dvalfre commented Feb 15, 2019

@thbar following up here. The minor versions jump was introduced on PR #377, which was included on release v5-3.0.54.
As for the 'upgrade stack' path, it continues to be the recommended way to upgrade the version of the EY Stack serving an environment. Having said that, we recognize customers may want to upgrade/downgrade specific versions of packages independently of the process, hence the overlay method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants