Use ETag from headers when parsing If-Range in FileResponse #2761
+19
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FileResponse.set_stat_headers()
takes care not to overwrite any headers set on the response, butFileResponse._should_use_range()
ignores any set headers and unconditionally uses its own ETag and Last-Modified calculation. This commit rectifies that.I have chosen to code
self.headers[
HEADER]
instead ofself.headers.get(
HEADER)
, becauseFileResponse.__call__()
always callsset_stat_headers()
and therefore the headers should always be set.Checklist