Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"For consideration" :-)
Closes #138
Based on work in encode/httpx#511
I think it turns out the best option is really just to add
uds=...
support like forlocal_address
. UDS is just a different network transport layer than TCP, but all of HTTP still applies, and so we can reuse our connection pool, HTTPS support, HTTP/2 support, etc.It's a bit disappointing because it'd be nice it this was easy to create as a separate transport, but a/ reusing the connection pool while customizing how the socket is established is pretty much impossible, and b/ re-implementing everything just to change a few lines in
AsyncConnectionPool
andAsyncHTTPConnection
seems overkill (and if I had to implement this as a third-party package, I'd find it pretty daunting).