Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing caller id data #120

Closed
emxsys opened this issue Nov 5, 2020 · 0 comments · Fixed by #122
Closed

Handle missing caller id data #120

emxsys opened this issue Nov 5, 2020 · 0 comments · Fixed by #122
Assignees
Labels
task Not a bug or new feature
Milestone

Comments

@emxsys
Copy link
Owner

emxsys commented Nov 5, 2020

Some telcos do not provide all the caller id fields. Fields other than the NMBR should be optional.

From callattendant forum message:

I'm in the process of getting this package to work in UK using USRobotics 5637 and Raspberry PI A+
So far I have had to add a line 204 to modem.py
call_record['NAME'] = "" because the UK CLI doesn't seem support this field..

From another callattendant forum message:

My test call wasn't displayed because the phone didn't provide the DATE and TIME fields. As a result I've modified modem.py to initialise call_record prior to searching for the data from readline().
now=datetime.now()
call_record['DATE']=now.strftime("%m%d")
call_record['TIME']=now.strftime("%H%M")
call_record['NAME']="Unknown"

@emxsys emxsys added the task Not a bug or new feature label Nov 5, 2020
@emxsys emxsys added this to the Release 1.1 milestone Nov 5, 2020
@emxsys emxsys self-assigned this Nov 5, 2020
emxsys added a commit that referenced this issue Nov 6, 2020
- Modem populates missing caller info with default data.
- Re: #120
@emxsys emxsys changed the title Make caller id fields configurable Handle missing caller id data Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Not a bug or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant