Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scenario settings #21

Closed
1 of 3 tasks
henhuy opened this issue Mar 1, 2024 · 1 comment · Fixed by #61
Closed
1 of 3 tasks

Implement scenario settings #21

henhuy opened this issue Mar 1, 2024 · 1 comment · Fixed by #61
Assignees
Labels
enhancement 🚀 New feature or request

Comments

@henhuy
Copy link
Contributor

henhuy commented Mar 1, 2024

Right now the user can select a scenario at the third menu step.
In my understanding, selecting a scenario will preset the controls for the next menu.

Regarding this approach, I have one question @nesnoj :
What happens if user selects a scenario and changes a slider in the next menu afterwards?
Does a new scenario "Custom settings" appear when going back to scenario menu?
Or are the sliders and switches are disabled if a predefined scenario is selected? (I think not, right?)

TODOS:

  • prepare a folder containing config files for each scenario
  • adapt controls from config file if user selects a scenario (maybe, a certain order has to be preserved, as slider ranges depend on detail settings)
  • ? select "custom scenario" if user changes sliders/switches? (see question above)
@henhuy henhuy added the enhancement 🚀 New feature or request label Mar 1, 2024
@henhuy henhuy self-assigned this Mar 1, 2024
@nesnoj
Copy link
Contributor

nesnoj commented Mar 15, 2024

I'll check this out next week

@josihoppe josihoppe linked a pull request Mar 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants