Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplemental Material URL entries should behave as links (not catalog searches) #693

Closed
eporter23 opened this issue Dec 19, 2024 · 2 comments
Assignees
Labels
Backend bug Something isn't working Frontend

Comments

@eporter23
Copy link
Contributor

eporter23 commented Dec 19, 2024

On the View Work page, when a URL has been entered for Supplemental Material, a hyperlink displays on the View Work page.

Currently, the hyperlink resolves to a Self Deposit catalog search.
We should revise this so the hyperlinks actually resolve to the URL entered for that field (related_datasets).

See the behavior already implemented for the Final Published Version URL (final_published_versions).

This ticket may also relate to #694.

See this record as an example: https://oe24-test.libraries.emory.edu/concern/publications/a6acc764-c2ba-4952-afaa-7611eea50f2f?locale=en

@eporter23 eporter23 added Backend bug Something isn't working Frontend labels Dec 19, 2024
@CB987 CB987 self-assigned this Jan 11, 2025
@CB987
Copy link
Contributor

CB987 commented Jan 11, 2025

i got this working by changing out the renderer from faceted to external link attribute (thanks to brad for the hot tips), and then pulled the renderer file into our repo in order to add functionality so that it would open in a new tab.
Screenshot 2025-01-10 at 8.16.43 PM.png
i may need to coordinate with @alexBLR to make sure there aren't any conflicts with the attributes file.

@eporter23
Copy link
Contributor Author

Thanks @CB987 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working Frontend
Projects
None yet
Development

No branches or pull requests

2 participants