Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyatomicEntity <- is a - Macromolecule - looks more like a tautology #283

Open
markdoerr opened this issue Mar 5, 2024 · 2 comments
Open

Comments

@markdoerr
Copy link

This class - subclass relationship:
PolyatomicEntity <- is a - Macromolecule

looks more like a tautology.
If there is no strong motivation to keep it, I would remove the Macromolecule subclass.

@jesper-friis
Copy link
Contributor

Thanks. These classes lacks elucidations and should definitely be revised.

@emanueleghedini
Copy link
Member

I agree that there is a lack of elucidations. However they refer to different concepts. A polyatomic entity is literally an entity made of two or more atoms. A macromolecule is according to IUPAC "a molecule of high relative molecular mass, the structure of which essentially comprises the multiple repetition of units derived, actually or conceptually, from
molecules of low relative molecular mass."

I'll keep this issue open, since chemistry branch will be revised after 1.0.0 release (January 2025).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants