From a5a4c688b1b0329b2aea71f2e6c49a48b3e757b1 Mon Sep 17 00:00:00 2001 From: Tenshin Higashi Date: Wed, 8 Nov 2023 11:04:15 -0500 Subject: [PATCH 1/2] Revert "Updating Agent" This reverts commit 81de0a26fc57b23587ccdce33ce321a05e8d6e07. Signed-off-by: Tenshin Higashi --- charts/emissary-ingress/Chart.lock | 6 +- charts/emissary-ingress/Chart.yaml.in | 2 +- manifests/emissary/emissary-defaultns.yaml.in | 68 +++++++++---------- .../emissary/emissary-emissaryns.yaml.in | 68 +++++++++---------- 4 files changed, 72 insertions(+), 72 deletions(-) diff --git a/charts/emissary-ingress/Chart.lock b/charts/emissary-ingress/Chart.lock index 4bd81d9233..1489418366 100644 --- a/charts/emissary-ingress/Chart.lock +++ b/charts/emissary-ingress/Chart.lock @@ -1,6 +1,6 @@ dependencies: - name: ambassador-agent repository: https://s3.amazonaws.com/datawire-static-files/charts - version: 1.0.20 -digest: sha256:456db1b8c5478e0a373231fa3284fc181b146dd4e88abc19fd11916cb667a1f4 -generated: "2023-11-07T01:18:03.271677-05:00" + version: 1.0.18 +digest: sha256:e3e849f13219638d9f10874165c6026bea1598cb487b77cc309cb60d82fed00b +generated: "2023-11-03T12:55:18.614119-04:00" diff --git a/charts/emissary-ingress/Chart.yaml.in b/charts/emissary-ingress/Chart.yaml.in index b420db0014..7f661a7f9b 100644 --- a/charts/emissary-ingress/Chart.yaml.in +++ b/charts/emissary-ingress/Chart.yaml.in @@ -28,7 +28,7 @@ maintainers: email: thigashi@datawire.io dependencies: - name: ambassador-agent - version: 1.0.20 + version: 1.0.18 repository: https://s3.amazonaws.com/datawire-static-files/charts condition: agent.enabled alias: agent diff --git a/manifests/emissary/emissary-defaultns.yaml.in b/manifests/emissary/emissary-defaultns.yaml.in index 50d989dc2f..bfd91d5051 100644 --- a/manifests/emissary/emissary-defaultns.yaml.in +++ b/manifests/emissary/emissary-defaultns.yaml.in @@ -439,8 +439,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-applications rules: @@ -460,8 +460,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-default-ns rules: @@ -481,8 +481,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-deployments rules: @@ -503,8 +503,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-endpoints rules: @@ -525,8 +525,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-ingresses rules: @@ -547,8 +547,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-pods rules: @@ -568,8 +568,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-rollouts rules: @@ -595,8 +595,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent rules: [] --- @@ -607,8 +607,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent roleRef: apiGroup: rbac.authorization.k8s.io @@ -626,12 +626,12 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent namespace: default spec: - replicas: 1 + replicas: null selector: matchLabels: app.kubernetes.io/instance: emissary-ingress @@ -654,7 +654,7 @@ spec: value: emissary-ingress-agent-cloud-token - name: RPC_CONNECTION_ADDRESS value: https://app.getambassador.io/ - image: docker.io/ambassador/ambassador-agent:1.0.20 + image: docker.io/ambassador/ambassador-agent:1.0.18 imagePullPolicy: IfNotPresent name: agent ports: @@ -672,8 +672,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent-config namespace: default rules: @@ -704,8 +704,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent-leaderelection namespace: default rules: @@ -723,8 +723,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent-config namespace: default roleRef: @@ -743,8 +743,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent-leaderelection namespace: default roleRef: @@ -763,8 +763,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent namespace: default spec: @@ -784,7 +784,7 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent namespace: default diff --git a/manifests/emissary/emissary-emissaryns.yaml.in b/manifests/emissary/emissary-emissaryns.yaml.in index ef5c1611d9..2baef4f715 100644 --- a/manifests/emissary/emissary-emissaryns.yaml.in +++ b/manifests/emissary/emissary-emissaryns.yaml.in @@ -439,8 +439,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-applications rules: @@ -460,8 +460,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-default-ns rules: @@ -481,8 +481,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-deployments rules: @@ -503,8 +503,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-endpoints rules: @@ -525,8 +525,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-ingresses rules: @@ -547,8 +547,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-pods rules: @@ -568,8 +568,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 rbac.getambassador.io/role-group: emissary-ingress-agent name: emissary-ingress-agent-rollouts rules: @@ -595,8 +595,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent rules: [] --- @@ -607,8 +607,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent roleRef: apiGroup: rbac.authorization.k8s.io @@ -626,12 +626,12 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent namespace: emissary spec: - replicas: 1 + replicas: null selector: matchLabels: app.kubernetes.io/instance: emissary-ingress @@ -654,7 +654,7 @@ spec: value: emissary-ingress-agent-cloud-token - name: RPC_CONNECTION_ADDRESS value: https://app.getambassador.io/ - image: docker.io/ambassador/ambassador-agent:1.0.20 + image: docker.io/ambassador/ambassador-agent:1.0.18 imagePullPolicy: IfNotPresent name: agent ports: @@ -672,8 +672,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent-config namespace: emissary rules: @@ -704,8 +704,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent-leaderelection namespace: emissary rules: @@ -723,8 +723,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent-config namespace: emissary roleRef: @@ -743,8 +743,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent-leaderelection namespace: emissary roleRef: @@ -763,8 +763,8 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent namespace: emissary spec: @@ -784,7 +784,7 @@ metadata: app.kubernetes.io/instance: emissary-ingress app.kubernetes.io/managed-by: Helm app.kubernetes.io/name: agent - app.kubernetes.io/version: 1.0.20 - helm.sh/chart: agent-1.0.20 + app.kubernetes.io/version: 1.0.18 + helm.sh/chart: agent-1.0.18 name: emissary-ingress-agent namespace: emissary From cf7ad46a89a5c92f4b2606aa35cd7143787420d5 Mon Sep 17 00:00:00 2001 From: Tenshin Higashi Date: Wed, 8 Nov 2023 11:04:59 -0500 Subject: [PATCH 2/2] Revert "Moving agent helm chart to dependency (#5328)" This reverts commit c5fc4a7ce46627b69a1a5659a8d85f8d0519a471. Signed-off-by: Tenshin Higashi --- .github/actions/setup-deps/action.yml | 7 +- Makefile | 24 +- build-aux/generate.mk | 6 +- build-aux/main.mk | 1 - charts/emissary-ingress/Chart.lock | 6 - charts/emissary-ingress/Chart.yaml.in | 27 +- charts/emissary-ingress/ci.in/ct.sh | 7 - charts/emissary-ingress/ct.yaml | 3 - .../templates/ambassador-agent.yaml | 284 +++++++++++++ charts/emissary-ingress/values.yaml.in | 34 +- k8s-config/emissary-defaultns/require.yaml | 33 +- k8s-config/emissary-defaultns/values.yaml | 4 - k8s-config/emissary-emissaryns/require.yaml | 30 +- k8s-config/emissary-emissaryns/values.yaml | 3 - manifests/emissary/emissary-defaultns.yaml.in | 389 ++++++++---------- .../emissary/emissary-emissaryns.yaml.in | 389 ++++++++---------- 16 files changed, 683 insertions(+), 564 deletions(-) delete mode 100644 charts/emissary-ingress/Chart.lock delete mode 100644 charts/emissary-ingress/ci.in/ct.sh create mode 100644 charts/emissary-ingress/templates/ambassador-agent.yaml diff --git a/.github/actions/setup-deps/action.yml b/.github/actions/setup-deps/action.yml index 960def637b..9326a19831 100644 --- a/.github/actions/setup-deps/action.yml +++ b/.github/actions/setup-deps/action.yml @@ -34,9 +34,4 @@ runs: - name: "Install Python requirements with pip" shell: bash run: python -m pip install awscli packaging - # Helm Deps - - name: "Install Helm Dependencies" - shell: bash - run: | - helm repo add agent https://s3.amazonaws.com/datawire-static-files/charts - helm repo update + diff --git a/Makefile b/Makefile index 57cdd50570..18b45ca1e3 100644 --- a/Makefile +++ b/Makefile @@ -74,27 +74,6 @@ $(call module,ambassador,$(OSS_HOME)) include $(OSS_HOME)/build-aux/generate.mk include $(OSS_HOME)/build-aux/lint.mk -HELM_TEST_IMAGE = quay.io/helmpack/chart-testing:v3.10.1 -CHART_DIR := $(OSS_HOME)/build-output/chart-$(patsubst v%,%,$(VERSION))_$(patsubst v%,%,$(CHART_VERSION)).d -CT_EXEC = docker run --rm -v $(KIND_KUBECONFIG):/root/.kube/config -v $(CHART_DIR) --network host $(HELM_TEST_IMAGE) $(CHART_DIR)/ci.in/ct.sh - -chart/lint: preflight-dev-kubeconfig - $(CT_EXEC) lint --config /ct.yaml -.PHONY: chart/lint - -chart/k3d-test: preflight-dev-kubeconfig - # check if k3d is installed - @if ! command -v k3d 2> /dev/null ; then \ - printf 'k3d not installed, please do that'; \ - false; \ - fi -.PHONY: chart/k3d-test - -chart/test: chart/lint chart/k3d-test ci/setup-k3d - $(CT_EXEC) install --config /ct.yaml && \ - $(MAKE) chart/delete-cluster -.PHONY: chart/test - .git/hooks/prepare-commit-msg: ln -s $(OSS_HOME)/tools/hooks/prepare-commit-msg $(OSS_HOME)/.git/hooks/prepare-commit-msg @@ -111,10 +90,9 @@ deploy: push preflight-cluster $(MAKE) deploy-only .PHONY: deploy -deploy-only: preflight-dev-kubeconfig chart/test $(tools/kubectl) build-output/yaml-$(patsubst v%,%,$(VERSION)) $(boguschart_dir) +deploy-only: preflight-dev-kubeconfig $(tools/kubectl) build-output/yaml-$(patsubst v%,%,$(VERSION)) $(boguschart_dir) mkdir -p $(OSS_HOME)/build/helm/ && \ ($(tools/kubectl) --kubeconfig $(DEV_KUBECONFIG) create ns ambassador || true) && \ - helm dependency build && \ helm template ambassador --output-dir $(OSS_HOME)/build/helm -n ambassador $(boguschart_dir) \ --set createNamespace=true \ --set service.selector.service=ambassador \ diff --git a/build-aux/generate.mk b/build-aux/generate.mk index d4fc3e03df..df48b5be1d 100644 --- a/build-aux/generate.mk +++ b/build-aux/generate.mk @@ -207,11 +207,7 @@ helm.namespace.emissary-defaultns-migration = default # IF YOU'RE LOOKING FOR *.yaml: recipes, look in main.mk. -helm-dependency: $(boguschart_dir) - cd $(boguschart_dir) && helm dependency build -.PHONY: helm-dependency - -$(OSS_HOME)/k8s-config/%/helm-expanded.yaml: helm-dependency \ +$(OSS_HOME)/k8s-config/%/helm-expanded.yaml: \ $(OSS_HOME)/k8s-config/%/values.yaml \ $(boguschart_dir) helm template --namespace=$(helm.namespace.$*) --values=$(@D)/values.yaml $(or $(helm.name.$*),$*) $(boguschart_dir) >$@ diff --git a/build-aux/main.mk b/build-aux/main.mk index cc04f9a0f7..aa27fe4fcf 100644 --- a/build-aux/main.mk +++ b/build-aux/main.mk @@ -130,7 +130,6 @@ endif } $(tools/chart-doc-gen) -d $$@/README.md build-output/chart-%.tgz: build-output/chart-%.d - cd $< && helm dependency build helm package --destination=$< $< mv $