Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrokeKind not exposed #5442

Open
arkumar-jumptrading opened this issue Dec 6, 2024 · 0 comments
Open

StrokeKind not exposed #5442

arkumar-jumptrading opened this issue Dec 6, 2024 · 0 comments

Comments

@arkumar-jumptrading
Copy link

A recent pr f2815b4 introduced a new StrokeKind enum. However the StrokeKind is unable to be set by the developer and is automatically chosen during tessellation for shapes.

This breaks existing UIs that rely on the previous default behavior of Middle stroke. For example an allocated rect's stroke isn't visible by default since its outside of the clip rect. There needs to ability for devs to specifically choose StrokeKind for a certain stoke being applied.

From @juancampa PR:

Tessellator will now use StrokeKind::Outside for closed shapes like
rect, ellipse, etc. And StrokeKind::Middle for the rest since there's
no meaningful "outside" concept for open paths. This PR doesn't expose
StrokeKind to user-land, but we can implement that later so that users
can render shapes and decide where to place the stroke.

@arkumar-jumptrading arkumar-jumptrading changed the title StrokeKind is unable to be set StrokeKind not exposed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant