Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building from git fails after #5320 #5331

Closed
lucasmerlin opened this issue Oct 30, 2024 · 0 comments · Fixed by #5336
Closed

Building from git fails after #5320 #5331

lucasmerlin opened this issue Oct 30, 2024 · 0 comments · Fixed by #5336
Assignees
@lucasmerlin
Labels
bug Something is broken eframe Relates to epi and eframe

Comments

@lucasmerlin
Copy link
Collaborator

lucasmerlin commented Oct 30, 2024 •
edited
Loading

#5320 moved all pngs to lfs, now when using eframe as a git dependency, the egui icon doesn't load because the repo isn't cloned with lfs. So we should make a lfs exception for the egui icon.

cat icon.png 
version https://git-lfs.github.com/spec/v1
oid sha256:31bbc7de655ccdf16efb6adb9959b5c6b9318befa0cdae88499b072549a55e3f
size 17166
@lucasmerlin lucasmerlin added the bug Something is broken label Oct 30, 2024
@lucasmerlin lucasmerlin changed the title Building from git fails after # Building from git fails after #5320 Oct 30, 2024
@lucasmerlin lucasmerlin self-assigned this Nov 1, 2024
@lucasmerlin lucasmerlin added the eframe Relates to epi and eframe label Nov 1, 2024
@lucasmerlin lucasmerlin mentioned this issue Nov 1, 2024
Merged
1 task
@emilk emilk closed this as completed in bbbd936 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasmerlin lucasmerlin

Labels
bug Something is broken eframe Relates to epi and eframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude icon.png from lfs emilk/egui
1 participant
@lucasmerlin