Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting PERF_WARNING: request_discard has been called X frames in a row #5132

Closed
kjarosh opened this issue Sep 19, 2024 · 1 comment · Fixed by #5133
Closed

Getting PERF_WARNING: request_discard has been called X frames in a row #5132

kjarosh opened this issue Sep 19, 2024 · 1 comment · Fixed by #5133
Assignees
@lucasmerlin
Labels
bug Something is broken egui

Comments

@kjarosh
Copy link

kjarosh commented Sep 19, 2024

Describe the bug

After updating to the latest master, the following warning started to appear:

To Reproduce
Steps to reproduce the behavior:

  1. Open Ruffle (the newest code from master https://github.com/ruffle-rs/ruffle, should be available tomorrow as a nightly release)
  2. Expand "Movie Parameters"
  3. Move your mouse

Expected behavior

No warning

Desktop (please complete the following information):

  • OS: Fedora
  • Browser N/A
  • Version 40

Additional context

That started happening after upgrading from f4697bc to e0f0b7f. Possibly related to #5059

Here's the related code in Ruffle: https://github.com/ruffle-rs/ruffle/blob/309d600c6daa400ac02d8aff5ee60d0cda670f6c/desktop/src/gui/dialogs/open_dialog.rs#L537. It started happening after ruffle-rs/ruffle#17987

CC @torokati44
@kjarosh kjarosh added the bug Something is broken label Sep 19, 2024
@lucasmerlin lucasmerlin self-assigned this Sep 19, 2024
@lucasmerlin
Copy link
Collaborator

This seems to be caused by the empty Grid. I think because nothing is added the Grid doesn't save it's state, so it thinks it's always the first frame and requests a discard. This is definitely a egui bug, thanks for reporting!

lucasmerlin added a commit that referenced this issue Sep 19, 2024
@lucasmerlin
Fix empty grids repeatedly requesting a discard
07399c5 
fixes #5132
@lucasmerlin lucasmerlin mentioned this issue Sep 19, 2024
Merged
1 task
emilk pushed a commit that referenced this issue Sep 20, 2024
@lucasmerlin
Fix empty grids repeatedly requesting a discard (#5133)
9ba97a9 
* Closes <#5132>
* [x] I have followed the instructions in the PR template

This does cause a slight difference in the amount of space allocated by
a empty grid, is this a problem?
Before:

<img width="113" alt="image"
src="https://github.com/user-attachments/assets/88c9c1a8-2ab8-4b01-8d57-0eb0655fa0e4">

After:

<img width="101" alt="image"
src="https://github.com/user-attachments/assets/8e1c9d1b-54d6-43b9-9e37-2614dd90d6fe">
@torokati44 torokati44 mentioned this issue Sep 20, 2024
Merged
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@lucasmerlin @hacknus
Fix empty grids repeatedly requesting a discard (emilk#5133)
efe959a 
* Closes <emilk#5132>
* [x] I have followed the instructions in the PR template

This does cause a slight difference in the amount of space allocated by
a empty grid, is this a problem?
Before:

<img width="113" alt="image"
src="https://github.com/user-attachments/assets/88c9c1a8-2ab8-4b01-8d57-0eb0655fa0e4">

After:

<img width="101" alt="image"
src="https://github.com/user-attachments/assets/8e1c9d1b-54d6-43b9-9e37-2614dd90d6fe">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasmerlin lucasmerlin

Labels
bug Something is broken egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix empty grids repeatedly requesting a discard emilk/egui
2 participants
@kjarosh @lucasmerlin