Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize eframe persistence file path #3927

Closed
C0D3-M4513R opened this issue Jan 31, 2024 · 4 comments
Closed

Customize eframe persistence file path #3927

C0D3-M4513R opened this issue Jan 31, 2024 · 4 comments

Comments

@C0D3-M4513R
Copy link

C0D3-M4513R commented Jan 31, 2024

Is your feature request related to a problem? Please describe.

When making an app, where you want to allow saving to a custom location (e.g. because you want your users to be able to work on multiple projects at once), you basically have to create a custom eframe::Storage implementation, which for me boils down to just copying the file that eframe::native::FileStorage resides in, removing the profiler macros and making the eframe::native::FileStorage::from_ron_filepath public.

Describe the solution you'd like

just make eframe::native::FileStorage::from_ron_filepath public

Describe alternatives you've considered

just copy the existing implementation

Additional context

@emilk emilk added this to the Next Major Release milestone Feb 1, 2024
@emilk
Copy link
Owner

emilk commented Feb 1, 2024

Sure - you wanna make a PR? 🙏

@emilk emilk changed the title make eframe::native::FileStorage::from_ron_filepath public Customize eframe persistence file path Jun 19, 2024
@YgorSouza
Copy link
Contributor

Did #4423 resolve this?

@C0D3-M4513R
Copy link
Author

C0D3-M4513R commented Jul 2, 2024

Not really no. I was thinking of being able to load/save from multiple different locations during the lifetime of an app (without re-creating the window). Something like being able to choose a project file to load/save to.

Your pr seems like it fixes the directory location on application start.

@emilk
Copy link
Owner

emilk commented Dec 11, 2024

I'll mark this as closed by #4423
If you have further requests, please open a new issue

@emilk emilk closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants