App::max_size_points limits webGL canvas to 1024px width silently -- Make settable? #453
AriYoung00
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
Just override This is a common question, so what is needed is some better communication of this, the question is where to put that. Where did you go looking for a solution? EDIT: I have improved the docs in ec6268e |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello all --
Just spend a couple hours banging my head against the wall trying to figure out why I couldn't make the webGL canvas for my app grow wider than 1024 pixels. Turns out,
App::max_size_points
returns[1024, 2048]
by default, limiting the maximum possible width to 1024 pixels. Note that this is called on every (I think?) render cycle, so changing the canvas size manually withegui_web::resize_canvas_to_screen_size
is not possible either. I understand that the width is limited in order to preserve performance in some browsers; however, I believe thatmax_size_points
should probably be settable by the user, rather than an arbitrary hard-coded limit. My application, for example, does not work properly at this width. If this is something that would be well-received, I would be more than happy to put together a PR making the requisite changes to theApp
trait.Thanks!
Beta Was this translation helpful? Give feedback.
All reactions