Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest LTS is incompatible with ember-cli v5.12.0 #9545

Closed
mkszepp opened this issue Oct 8, 2024 · 1 comment
Closed

Latest LTS is incompatible with ember-cli v5.12.0 #9545

mkszepp opened this issue Oct 8, 2024 · 1 comment

Comments

@mkszepp
Copy link
Contributor

mkszepp commented Oct 8, 2024

The latest EmberData package (v5.3.8) is not anymore compabile with latest ember-cli version (5.12.0).

This is because ember-cli has updated all dependency to latest.

When you try to create a new app you will run immediately into an error while build.

Steps to reproduce:

  1. ember new my-app --embroider
  2. ember s

Error:

Some V1 ember addons are resolving as incorrect peer dependencies. This makes it impossible for us to safely convert them to v2 format.

  👇 👇 👇
👉 See https://github.com/embroider-build/embroider/blob/main/docs/peer-dependency-resolution-issues.md for an explanation of the problem and suggestions for fixing it.
  👆 👆 👆

[email protected] (dev)-> [email protected] -> @ember-data/[email protected]
    sees peerDep @ember/[email protected]
      at /home/user/projects/test/my-app/node_modules/ember-data/node_modules/@ember/string
    but [email protected] is using @ember/[email protected]
      at /home/user/projects/test/my-app/node_modules/@ember/string



  👇 👇 👇
👉 See https://github.com/embroider-build/embroider/blob/main/docs/peer-dependency-resolution-issues.md for an explanation of the problem and suggestions for fixing it.
  👆 👆 👆


Stack Trace and Error Report: /tmp/error.dump.0ff588b5e8449e76c30d9508b6ecbc5c.log

This occures because ember-data has in LTS no support for @ember/string v4.0.0

Fix

Backporting the allow of peerDependency as patch should resolve everythink for now, since ember-data is shipping next minor version

Workaroud

Apps must downgrade @ember/string for compatiblity or using overrides to fix this issue

@runspired
Copy link
Contributor

Resolved in 5.3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants