Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a percy snapshot for the expanded mobile menu #139

Open
mansona opened this issue May 4, 2023 · 3 comments
Open

Add a percy snapshot for the expanded mobile menu #139

mansona opened this issue May 4, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@mansona
Copy link
Member

mansona commented May 4, 2023

We curren't don't have any percy snapshots for the expanded percy menu. I'm not entirely sure if we can have a percy snapshot for just one particular size 🤔 but it would be nice if it were possible.

@mansona mansona added help wanted good first issue Good for newcomers labels May 4, 2023
@jenweber
Copy link
Contributor

jenweber commented May 4, 2023

Yes, you can do size changes for individual snapshots!

https://docs.percy.io/docs/cli-configuration#per-snapshot-configuration

https://docs.percy.io/docs/ember

@DeRaowl
Copy link

DeRaowl commented Jul 29, 2023

Hey Manson, Would love to work on this issue?

@MinThaMie
Copy link
Contributor

This is more complicated than it looks, because we need to also press the button to see what is in the menu and not only resize the Percy screenshots. I've not yet figured out how to resize the window, press the button and then take the screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants