Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

HTML Reporter never updates it's progress, and never sets the "finished" class on the #mocha div #151

Open
fushi opened this issue Dec 1, 2016 · 10 comments
Labels

Comments

@fushi
Copy link

fushi commented Dec 1, 2016

We use this in our CI to tell when the tests finish. Is there a workaround?

@Turbo87
Copy link
Member

Turbo87 commented Dec 1, 2016

@fushi can you elaborate? I'm not quite sure what you're talking about

@Turbo87 Turbo87 added the bug label Dec 1, 2016
@fushi
Copy link
Author

fushi commented Dec 1, 2016

screen shot 2016-12-01 at 12 57 31 pm

@fushi
Copy link
Author

fushi commented Dec 1, 2016

The tests are done in that picture, but the completed percent shows as 0%, and the Mocha window is still yellow, because

doesn't have class="finished"

@Turbo87
Copy link
Member

Turbo87 commented Dec 1, 2016

@fushi this looks like you are not using the default reporter. can you provide a repository to reproduce your issues?

@fushi
Copy link
Author

fushi commented Dec 1, 2016

That is the default reporter, as far as I can tell. I've done nothing but ember install ember-cli-mocha and rm -rf node_modules && npm install.

Then I run ember serve and browse to /tests/.

Can you show a screenshot of what you're expecting?

@Turbo87
Copy link
Member

Turbo87 commented Dec 2, 2016

@fushi I'm pretty sure that this has worked at some point in the past, but apparently it no longer does. I've been able to reproduce this in a fresh new app.

@Turbo87
Copy link
Member

Turbo87 commented Dec 2, 2016

We use this in our CI to tell when the tests finish.

why don't you use ember test instead?

@fushi
Copy link
Author

fushi commented Dec 3, 2016

We're moving from ember (non-cli) to ember-cli, and the current method of build/test for CI is the following:

Build on build server
Deploy to dev environment
Run selenium from build server using a grid of workers, against dev environment url with &grep= GET arguments.

I'm not opposed to changing that, I just don't yet know how we'd go about parallelizing test execution in the new way of doing things.

The main issue I'm having is that I need the test results back on the build server, but I'm not sure I can run anything graphical there (and phantomjs doesn't seem to run any of the integration tests)

@adamjmcgrath
Copy link

This was fixed in mochajs/mocha#2299 - but it's only in mocha 3.x

@Turbo87
Copy link
Member

Turbo87 commented Jan 25, 2017

good to know, thanks @adamjmcgrath! looks like we have one more reason to migrate to Mocha 3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants