Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

Region Staging doesn't work #4

Closed
CestDiego opened this issue Nov 6, 2015 · 8 comments
Closed

Region Staging doesn't work #4

CestDiego opened this issue Nov 6, 2015 · 8 comments

Comments

@CestDiego
Copy link

To reproduce: go into visual selection either with v or V in the magit-status buffer, inside a chunk... then try to move either up or down with j or k...the selection will dissapear.

@justbur
Copy link
Member

justbur commented Nov 6, 2015

It's working for me. I wonder if you just can't see the region because of your theme.

@CestDiego
Copy link
Author

No, I try to select and then stage and it stages the whole chunk instead of some region of it.

@justbur
Copy link
Member

justbur commented Nov 6, 2015

Yes, I understand. It works for me. I can stage part of a chunk. I'll need more information to diagnose this.

What does C-h k v say in a chunk? What about C-h k j? Should be set-mark-command and evil-next-visual-line respectively.

@CestDiego
Copy link
Author

I figured this out. It's got to do with me having evil-escape-sequence at jk...everything is bound to what it needs but it seems evil-escape is doing some stuff that blocks j or k...

@CestDiego
Copy link
Author

Must be related to syl20bnr/evil-escape#52

@justbur
Copy link
Member

justbur commented Nov 6, 2015

Ah ok. Maybe file an issue with evil-escape. I haven't used evil-escape in
a while so I didn't test against it.
On Fri, Nov 6, 2015 at 6:39 PM Diego Berrocal [email protected]
wrote:

I figured this out. It's got to do with me having evil-escape-sequence at
jk...everything is bound to what it needs but it seems evil-escape is
doing some stuff that blocks j or k...


Reply to this email directly or view it on GitHub
#4 (comment).

@justbur
Copy link
Member

justbur commented Nov 15, 2015

Noted in the readme so I'm going to close this for now. Please reopen if something changes

@justbur justbur closed this as completed Nov 15, 2015
@CestDiego
Copy link
Author

thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants