support monochrome mode #1714
Merged
support monochrome mode #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No color mode shouldn't affect what is actually stored in styled texts; it should only affect how they are printed. If users write code that uses styled texts but doesn't actually print them, it shouldn't be affected by NO_COLOR. I am also slightly torn on use of a global flag, but this one feels justified. It gives the user no way to opt out of the behavior, but that may actually be a good thing. |
Use NO_COLOR environment variable to enable monochrome mode in which foreground and background colors will be stripped. Signed-off-by: Tw <[email protected]>
|
@xiaq How about the updated version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #695