This repository has been archived by the owner on May 24, 2024. It is now read-only.
Fix for missing fee bump result (issue 388) #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopmiddelkamp
force-pushed
the
feature/fee_bump_result_support
branch
2 times, most recently
from
7651376
to
c20873e
Compare
jopmiddelkamp
force-pushed
the
feature/fee_bump_result_support
branch
from
c20873e
to
0de588b
Compare
|
@elucidsoft, could you check this PR? |
jopmiddelkamp
force-pushed
the
feature/fee_bump_result_support
branch
2 times, most recently
from
2e5faa1
to
effa08c
Compare
jopmiddelkamp
force-pushed
the
feature/fee_bump_result_support
branch
from
effa08c
to
2401341
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue 388.
Also fixed the fee bump fee according to the Stellar documentation.
https://developers.stellar.org/docs/encyclopedia/fee-bump-transactions#fee
It states that the fee set on the fee bump transaction should be the amount of stopen that you would like to pay for executing only the fee bump operation which is 1 operation. So this should be independent from the inner transaction.
Types of changes