-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erroneous declaration of functions in the class SoundData #33
Comments
Can you specify compiler? |
Visual Studio 2017 with last upgrade. |
It is called function hiding. Should be fixed to:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is an incorrect function declaration:
Because some compilers accept std::string for std::vector<uint8_t>. As a result, "virtual bool init (const std::string& filename);" not visible in the classes of the heirs. I suggest changing the name of the function "virtual bool init(const std::vector<uint8_t>& newData);" on "virtual bool initData(const std::vector <uint8_t>& newData);".
For example:
The text was updated successfully, but these errors were encountered: