Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code maintenance megathread #12

Open
LavenderTheGreat opened this issue May 17, 2020 · 0 comments
Open

Code maintenance megathread #12

LavenderTheGreat opened this issue May 17, 2020 · 0 comments

Comments

@LavenderTheGreat
Copy link
Contributor

We should get round to cleaning up (or grouping) various bits of the code, as of current it's 121 lines with almost zero comments, there is also a lot of functions that could be using preset arrays and designed more modularly.

Generally I think our course of action should be:

  • Comment code

  • Break up pieces of code that need to be split up into their own categories

  • Work on making the reaction stuff much more modular (Proposal: Probably an array with objects within, which list words/phrases to check for, and the reactions to put down when they are found)

  • Organise all this into a fancy settings object which also includes the roles to detect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant