Partially fix issues with #450, Mint Reduce Reponses. #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ref(), headers()}
|
Awesome! @crova Can we write some tests for this? |
|
Sure @teamon , I'll try to get that done this week. |
|
@crova any updates on this one? |
|
Sorry folks, I lost track of this one. Edit: Just FYI, I've started looking at adding tests to this PR. It's been a long time since I touch this so I'll need to do some catching up to remember where I left this one. Cheers. |
|
Hey folks, how is it going? Cheers. |
…educe-response-doesnt-handle-all-possible-responses
…educe-response-doesnt-handle-all-possible-responses
yordis
force-pushed
the
master
branch
6 times, most recently
from
2bca420 to
fe7207c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles {:push_promise, request_ref(), promised_request_ref :: request_ref(), headers()}.
And also {:error, ref, error} that seems to be missing as well.
Let me know if I can improve this @teamon .