diff --git a/lib/scholar/linear/isotonic_regression.ex b/lib/scholar/linear/isotonic_regression.ex index 8a9fb562..da76b825 100644 --- a/lib/scholar/linear/isotonic_regression.ex +++ b/lib/scholar/linear/isotonic_regression.ex @@ -173,6 +173,7 @@ defmodule Scholar.Linear.IsotonicRegression do false -> Nx.u8(0) end + # increasing = Nx.u8(1) fit_n(x, y, sample_weights, increasing, opts) diff --git a/lib/scholar/manifold/mds.ex b/lib/scholar/manifold/mds.ex index 879144ac..09281e02 100644 --- a/lib/scholar/manifold/mds.ex +++ b/lib/scholar/manifold/mds.ex @@ -159,8 +159,8 @@ defmodule Scholar.Manifold.MDS do dissimilarities = Distance.pairwise_euclidean(dissimilarities) {{best, best_stress, best_iter}, _} = - while {{best = x, best_stress = Nx.Constants.infinity(type), - best_iter = 0}, {n_init, dissimilarities, x, i = 0}}, + while {{best = x, best_stress = Nx.Constants.infinity(type), best_iter = 0}, + {n_init, dissimilarities, x, i = 0}}, i < n_init do {temp, stress, iter} = smacof(dissimilarities, x, opts[:max_iter], opts)