-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input type of "conv" does not allow u8 (f32 ok). #63
Comments
@ndrean thanks for the report. I've edited the issue to explain the problem and a suggested solution. Pull requests are welcome! |
"hack" is easy: |
I suggest Nx.Type.to_floating instead, as that will avoid upcasts from f16/f8 |
Humm, I tested
What I mean is that you should probably need to provide the "real" implementation in |
This is probably not a relevant conversation for this issue. I'm also not sure why the type would affect the ability to reverse an input. |
Ah, right. This is most likely just a bug in EMLX.Backend.reverse. |
Also, there is ongoing work on NxSignal.Convolutions :) |
Ok. It was because I wrongly used
|
(edited for clarity)
MLX does not support integer types in matrix multiplication nor convolutions.
Seeing as Nx always expects a floating/complex output from Nx.conv, we can do upcasts beforehand.
Complex conv might need the same trick used in Torchx.Backend
The text was updated successfully, but these errors were encountered: