Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docstring and minor refactoring #138

Merged
merged 3 commits into from
Mar 8, 2023
Merged

fix: docstring and minor refactoring #138

merged 3 commits into from
Mar 8, 2023

Conversation

Ayush5120
Copy link
Contributor

@Ayush5120 Ayush5120 commented Feb 20, 2023 •
edited
Loading

  • Addressed Fix docstrings #136.
  • refactor to use list comprehension.
  • Raised custom exception instead of using generic in the middleware module.

uniqueg
uniqueg requested changes Feb 21, 2023
View reviewed changes
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ayush5120!

Please split up into three PRs here, in this order:

  • feat: return specific error if no TES available
  • refactor: minor improvements on code clarity
  • docs: extend and correct docstrings

pro_tes/ga4gh/tes/models.py Outdated Show resolved Hide resolved
pro_tes/ga4gh/tes/task_runs.py Outdated Show resolved Hide resolved
pro_tes/ga4gh/tes/task_runs.py Outdated Show resolved Hide resolved
pro_tes/ga4gh/tes/task_runs.py Outdated Show resolved Hide resolved
pro_tes/ga4gh/tes/task_runs.py Outdated Show resolved Hide resolved
pro_tes/middleware/middleware.py Outdated Show resolved Hide resolved
pro_tes/middleware/middleware.py Outdated Show resolved Hide resolved
pro_tes/middleware/middleware.py Show resolved Hide resolved
pro_tes/middleware/task_distribution/distance.py Outdated Show resolved Hide resolved
pro_tes/middleware/task_distribution/distance.py Outdated Show resolved Hide resolved
@Ayush5120 Ayush5120 force-pushed the fix-codebase-docstrings branch 2 times, most recently from 1a727dc to a875233 Compare February 22, 2023 20:46
@Ayush5120 Ayush5120 requested a review from uniqueg February 24, 2023 16:33
@Ayush5120 Ayush5120 force-pushed the fix-codebase-docstrings branch from 008a797 to 477baf8 Compare March 7, 2023 23:55
@uniqueg uniqueg force-pushed the fix-codebase-docstrings branch from 680d438 to da213fe Compare March 8, 2023 01:42
@uniqueg uniqueg force-pushed the fix-codebase-docstrings branch from da213fe to dd0ec34 Compare March 8, 2023 01:47
@uniqueg uniqueg merged commit 4023804 into dev Mar 8, 2023
@uniqueg uniqueg deleted the fix-codebase-docstrings branch March 8, 2023 01:56
@Ayush5120 Ayush5120 mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniqueg uniqueg uniqueg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ayush5120 @uniqueg