Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report correct error at startSession #7

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Report correct error at startSession #7

merged 2 commits into from
Nov 28, 2024

Conversation

gmrchk
Copy link
Member

@gmrchk gmrchk commented Nov 27, 2024

Some browsers won't allow calling getSupportedConstraints before getting approval for microphone access. In such case we fail with random error of getSupportedConstraints being undefined, while we should fail on access.

Copy link

@hikmet-demir hikmet-demir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the addition, I will add this to documentation as well.

@gmrchk gmrchk merged commit 3f65271 into main Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants