Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS wheels fail to build with Rust v1.83.0 #17988

Open
1 of 2 tasks
anoadragon453 opened this issue Dec 3, 2024 · 1 comment
Open
1 of 2 tasks

MacOS wheels fail to build with Rust v1.83.0 #17988

anoadragon453 opened this issue Dec 3, 2024 · 1 comment
Assignees

Comments

@anoadragon453
Copy link
Member

anoadragon453 commented Dec 3, 2024

The build release artifacts CI job has begun to fail on develop since November 28th. This lines up with Rust's v1.83.0 release on the same day. This portion of the release notes caught my and @sandhose's eye:

Linking on macOS now correctly includes Rust’s default deployment target. Due to a linker bug, you might have to pass MACOSX_DEPLOYMENT_TARGET or fix your #[link] attributes to point to the correct frameworks. See rust-lang/rust#129369.

As a temporary solution, building MacOS wheels were disabled in order to get out the 1.120.1 release.

Addressing this properly can be done in two stages:

  • Pin the Rust version used when building MacOS wheels to 1.82.0. This will allow MacOS wheels to be created again.

    The rust version that is used for building wheels is determined here. Changing stable to 1.82.0 should work.

    This has been done in Pin Rust to 1.82.0 when building Python wheels #17993.

  • Fixing the issue properly on the most recent Rust versions. This may involve setting MACOSX_DEPLOYMENT_TARGET as the Rust 1.83.0 changelog notes?

Completing 1. is considered a release blocker for 1.121.0rc1.

@anoadragon453
Copy link
Member Author

The release blocker has been cleared by #17993 landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant