Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a dual CJS/ESM package with platform-specific loaders #30

Merged
merged 7 commits into from
Jan 2, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 4, 2024

Fixes #29
Requires #32
Requires #33

Based on matrix-org/matrix-rust-sdk-crypto-wasm#167 & matrix-org/matrix-rust-sdk-crypto-wasm#178

The -wasm subpackage is necessary to convince vite to not bundle the wasm as base64 in library mode, we bundle it instead of shipping it as hopefully in the future we can eradicate it.

@t3chguy t3chguy added T-Enhancement Improvement or feature request Web labels Dec 4, 2024
@t3chguy t3chguy self-assigned this Dec 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (b94addf) to head (f54ebcc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files          95       95           
  Lines       16574    16574           
  Branches      291      291           
=======================================
  Hits        14703    14703           
  Misses       1868     1868           
  Partials        3        3           
Flag Coverage Δ
unittests 88.71% <100.00%> (ø)
unittests-react 83.08% <100.00%> (ø)
unittests-rust 89.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t3chguy t3chguy changed the title Load wasm via fetch rather than base64 embedding Publish a dual CJS/ESM package with platform-specific loaders Dec 23, 2024
@t3chguy t3chguy changed the base branch from main to t3chguy/wasm-ts-yarn December 23, 2024 09:31
Base automatically changed from t3chguy/wasm-ts-yarn to main December 23, 2024 10:01
@t3chguy t3chguy changed the base branch from main to t3chguy/tidy-web December 23, 2024 10:06
@t3chguy t3chguy requested review from a team and florianduros and removed request for a team December 23, 2024 10:11
Base automatically changed from t3chguy/tidy-web to main December 23, 2024 10:25
@t3chguy t3chguy marked this pull request as ready for review December 23, 2024 11:06
Copy link
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@t3chguy t3chguy merged commit 161c24d into main Jan 2, 2025
9 checks passed
@t3chguy t3chguy deleted the t3chguy/wasm-asset branch January 2, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement Improvement or feature request Web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish a dual CJS/ESM package with platform-specific loaders
3 participants