-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish a dual CJS/ESM package with platform-specific loaders #30
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 88.71% 88.71%
=======================================
Files 95 95
Lines 16574 16574
Branches 291 291
=======================================
Hits 14703 14703
Misses 1868 1868
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b1b8ba8
to
69428b8
Compare
69428b8
to
83b3a88
Compare
83b3a88
to
4e55cbd
Compare
4e55cbd
to
b2694a7
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
Fixes #29
Requires #32
Requires #33
Based on matrix-org/matrix-rust-sdk-crypto-wasm#167 & matrix-org/matrix-rust-sdk-crypto-wasm#178
The
-wasm
subpackage is necessary to convince vite to not bundle the wasm as base64 in library mode, we bundle it instead of shipping it as hopefully in the future we can eradicate it.