Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user_password_login (Compat) generates a new device regardless if device_id is sent in the post request #3789

Open
maspling opened this issue Jan 11, 2025 · 0 comments

Comments

@maspling
Copy link

maspling commented Jan 11, 2025

Describe the bug
According to https://spec.matrix.org/v1.13/client-server-api/#post_matrixclientv3login , if a device_id is sent in the login request, and it is a previously known device id, the session should be reused and the the same device id should be returned in the response.

Looking at the current relevant code, it doesn't seem like device_id is ever read from the request payload and that a new device is created every time.

To Reproduce
Steps to reproduce the behavior:

  1. Create a device by completing login flow.
  2. Login again with a the same device_id.
  3. Response will be a newly generated device_id

Expected behavior
A new device is not created and the same one is reused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant