Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location shares could send thumbnails #3660

Open
ara4n opened this issue Jan 3, 2025 · 1 comment
Open

Location shares could send thumbnails #3660

ara4n opened this issue Jan 3, 2025 · 1 comment
Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product

Comments

@ara4n
Copy link
Member

ara4n commented Jan 3, 2025

Steps to reproduce

  1. Send a loc share on low data
  2. See a blurred placeholder thumbnail as both sender and receiver
  3. Wonder why it didn’t send an actual image thumbnail of the loc share, like we would have on an image xfer

Outcome

What did you expect?

Sender could capture an image thumbnail of the location and send it as an extensible event thumbnail.

This could backfire if it uses the wrong theme or i18n or location though, so perhaps it’s not the best idea

What happened instead?

Random blurred placeholder thumbnail

Your phone model

No response

Operating system version

No response

Application version

796

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Jan 3, 2025
@ara4n ara4n changed the title Location shares should send thumbnails Location shares could send thumbnails Jan 3, 2025
@pixlwave pixlwave added X-Needs-Product T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Location and removed T-Defect labels Jan 6, 2025
@pixlwave
Copy link
Member

pixlwave commented Jan 6, 2025

Wouldn't this result in slowing down the location share until there's

a) enough bandwidth to load the map tiles needed to create the thumbnail.
b) the thumbnail had been uploaded.

Considering the steps described above, as far as I can tell this wouldn't improve the experience for the sender as they would be staring at an unsent location for longer than they would the blurred placeholder 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product
Projects
None yet
Development

No branches or pull requests

2 participants