-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posthog: Add more properties to unable to decrypt errors to allow more filtering options #2332
Comments
These will also be improvements/addition to #2300 |
Is it better to log the age relative to the session, or to log the session-creation-time and the timestamp on the event as separate fields (and then do the calculation on the posthog side)? |
AFAIK There is no easy way to do that on posthog side (not in the query to display graphs), maybe a posthog plugin where you can pre-process and decorate events. |
isFederated |
It looks like other "time" fields in the analytics events measure time in milliseconds. Please let's try to be consistent. |
Trying to understand this a bit better. Could you explain what will happen under this plan for each of:
|
Yes so far I think:
The max wait period has to be defined, the main risk is that this wait time is too long and the client is closed meanwhile and the error not reported at all. So maybe it should be 30s and not 60s |
Yes, updated |
So do we do this instead of #2303? |
I think so, let's confirm at the daily |
Closed #2303 and do this task instead |
For UTD that are not resolved after the max_time, we might want to report |
@BillCarsonFr will break into separate tasks. |
@BillCarsonFr All the tasks in this issue are marked as done. Can this issue be closed, or is there more work to do here? |
yes let's close there is a roundoff for EX |
It looks like that was eventually implemented as |
Also, it has not been implemented for EW. |
Currently the captured
Error
events for unable to decrypt errors do not contain much information.This lack of information is preventing us from getting interesting insights from the raw data.
Goal: We want to add some new properties that will allow us to better filter out Posthog insights.
List of needed properties:
eventLocalAgeAtDecryptionFailure
eventLocalAgeMillis
(numeric, time in millis). An heuristic based on eventorigin_server_ts
and the current device creation time. This would be used to get the source of the event scrollback/live/initialSync. This would be used in Posthog by creating filter to group events in buckets (e.g <0 (historical), <60s, <5min, <1h, >1h)userTrustsOwnIdentity
(boolean). Would allow to know if the current session was trusted at the time of decryptionisFederated
(boolean).true
if userDomain!=
senderDomain. Would allow to filter UTDs where federation is involved.timeToDecryptMillis
(numeric, time in millis) : Currently there is a grace period of 4s, after that UTDs are reported. We would like to improve the existing mecanism by adding atimeToDecrypt
properties when an event is decrypted late. We should track decryption errors for 1mn (TBD), if events are decrypted during this period we still report an UTD with the time it took to decrypt, after 1mn we report anyhow. Would allow to filter on posthog temporary vs definitive UTD.isMatrixDotOrg
(boolean). True if the current user is using Matrix.org. Combined withisFederated
would allow to create a filter where we are sure that both users are running a recent synapse.wasVisibleToUser
(boolean). True if that unable to decrypt error was visible to the user. For example, some clients can hide part of the history and only show it after verification. In that case the UTDs won't be displayed on screen and we want to filter that.Tasks
The text was updated successfully, but these errors were encountered: