Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS sandbox #1728

Open
appleisshit opened this issue Jun 15, 2024 · 5 comments · May be fixed by #1730
Open

macOS sandbox #1728

appleisshit opened this issue Jun 15, 2024 · 5 comments · May be fixed by #1730
Labels
A-Packaging Packaging, signing, releasing T-Task Tasks for the team like planning Z-macOS Z-Platform-Specific

Comments

@appleisshit
Copy link

Your use case

What would you like to do?

Enable macOS app sandbox.

Why would you like to do it?

It states here that the macOS app sandbox is not enabled due to the electron-builder issue. But it was fixed more than 4 years ago. Enabling the sandbox will reduce harm from vulnerabilities such as GHSA-mjrg-9f8r-h3m7.

How would you like to achieve it?

Enable com.apple.security.app-sandbox entitlement.

Have you considered any alternatives?

No response

Additional context

No response
@dosubot dosubot bot added the T-Feature Request to add a new feature which does not exist right now label Jun 15, 2024
@dbkr dbkr added T-Task Tasks for the team like planning A-Packaging Packaging, signing, releasing Z-Platform-Specific and removed T-Enhancement T-Feature Request to add a new feature which does not exist right now labels Jun 17, 2024
@t3chguy
Copy link
Member

t3chguy commented Jun 17, 2024 •
edited
Loading

https://www.electronjs.org/docs/latest/tutorial/mac-app-store-submission-guide#limitations-of-mas-build implies that enabling app sandboxing breaks a few things including crashReporter and more critically autoUpdater. If that is the case then the sandboxing would be blocked by #655

@appleisshit
Copy link
Author

https://www.electronjs.org/docs/latest/tutorial/mac-app-store-submission-guide#limitations-of-mas-build implies that enabling app sandboxing breaks a few things including crashReporter and more critically autoUpdater. If that is the case then the sandboxing would be blocked by #655

But also #655 would be blocked by this. You can provide two versions, one unsandboxed with auto-updates and one sandboxed from the Mac App Store.

@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2024 •
edited
Loading

We don't have plans or resources to ship, test, and maintain two different releases. So it'd be one or the other.

@appleisshit
Copy link
Author

We don't have plans or resources to ship, test, and maintain two different releases. So it'd be one or the other.

Then how will existing installations be converted to the sandboxed version? They will have to manually reinstall from the Mac App Store.

@t3chguy
Copy link
Member

t3chguy commented Jul 22, 2024

Yes, there could be a final update which features a guide on how to transition if the management decide that we wish to move to MAS.

@t3chguy t3chguy linked a pull request Nov 4, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Packaging Packaging, signing, releasing T-Task Tasks for the team like planning Z-macOS Z-Platform-Specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable macOS app sandbox via entitlements element-hq/element-desktop
3 participants
@dbkr @t3chguy @appleisshit