Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio mute button in lobby view causes video to reload #2867

Open
hughns opened this issue Dec 4, 2024 · 2 comments
Open

Audio mute button in lobby view causes video to reload #2867

hughns opened this issue Dec 4, 2024 · 2 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@hughns
Copy link
Member

hughns commented Dec 4, 2024

This feels like it is totally unnecessary and isn't consistent UX with what happens when you are inside a call.

@hughns hughns added T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 4, 2024
@Half-Shot
Copy link
Member

The problem is usePreviewTracks (

const tracks = usePreviewTracks(localTrackOptions, onError);
) will recreate both tracks each time the options property is mutated, even if no change is made to one track.

The function itself is relatively trivial, so we could reimplement it with better tracking of existing tracks if we wanted or attempt to commit a fix upstream to livekit.

@robintown
Copy link
Member

I'm planning to do a bit of a refactor in which the LiveKit room becomes created at a higher point in the component tree, and instead of using this hook from LiveKit, we just use the local participant's tracks on the room as the video preview. This would also have the advantage of not reacquiring media when you enter the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

No branches or pull requests

3 participants